Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-22 Thread Michael Young
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- (Updated July 22, 2014, 3:22 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-21 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/#review12774 --- Ship it! /trunk/main/bridge_channel.c

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-18 Thread Michael Young
On July 16, 2014, 8:23 p.m., rmudgett wrote: /trunk/main/bridge_channel.c, lines 875-876 https://reviewboard.asterisk.org/r/3819/diff/1/?file=64628#file64628line875 I think you want strlen(app_args) + 1 instead of sizeof(app_args) which returns the size of a pointer. I'm

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-18 Thread Michael Young
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- (Updated July 18, 2014, 4:51 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-16 Thread Michael Young
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22608

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/#review12701 --- /trunk/main/bridge_channel.c