Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-08-06 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated Aug. 6, 2014, 7:55 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12984 --- trunk/main/stasis_message.c

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-08-05 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated Aug. 5, 2014, 9:46 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-08-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12988 --- Ship it! Ship It! - Matt Jordan On Aug. 5, 2014, 9:46

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-29 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 29, 2014, 2:14 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-24 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12858 --- trunk/include/asterisk/stasis.h

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-21 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12785 --- trunk/main/stasis.c

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-21 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 21, 2014, 12:37 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-21 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12793 --- trunk/main/stasis_message.c

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-21 Thread opticron
On July 21, 2014, 2:25 p.m., Mark Michelson wrote: trunk/main/stasis_message.c, lines 84-91 https://reviewboard.asterisk.org/r/3823/diff/7/?file=64893#file64893line84 Can you describe the reason this function was made NULL-safe? Did you encounter a situation in testing where a

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-21 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 21, 2014, 2:58 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-21 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 21, 2014, 4:39 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12740 --- trunk/configs/samples/stasis.conf.sample

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 18, 2014, 9:54 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12756 --- trunk/main/stasis.c

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 18, 2014, 12:22 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-17 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 17, 2014, 7:49 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-17 Thread Paul Belanger
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12709 --- Could you maybe explain why this is needed? I couldn't find

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-17 Thread Matt Jordan
On July 17, 2014, 9:43 a.m., Paul Belanger wrote: Could you maybe explain why this is needed? I couldn't find anything on Jira / wiki that explained the need. I assume it is because of performance issues? This patch is the 'sledgehammer' option for tweaking your system's performance.

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-17 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12736 --- trunk/configs/stasis.conf.sample

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-17 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 17, 2014, 10:47 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-16 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- Review request for Asterisk Developers and Corey Farrell. Repository: