Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-19 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/ --- (Updated Aug. 19, 2014, 11:21 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/#review13095 --- /branches/12/res/res_stasis.c

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Jonathan Rose
On Aug. 18, 2014, 9:24 a.m., Joshua Colp wrote: /branches/12/res/res_stasis.c, lines 1330-1333 https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330 Add a comment explaining why this is being done. Honestly, I don't believe this is necessary and as far as I

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
On Aug. 18, 2014, 2:24 p.m., Joshua Colp wrote: /branches/12/res/res_stasis.c, lines 1330-1333 https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330 Add a comment explaining why this is being done. Jonathan Rose wrote: Honestly, I don't believe this is

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Jonathan Rose
On Aug. 18, 2014, 9:24 a.m., Joshua Colp wrote: /branches/12/res/res_stasis.c, lines 1330-1333 https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330 Add a comment explaining why this is being done. Jonathan Rose wrote: Honestly, I don't believe this is

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/ --- (Updated Aug. 18, 2014, 10:27 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/#review13102 --- Ship it! Ship It! /branches/12/res/res_stasis.c

[asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-15 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24043

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-15 Thread Krandon Bruse
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/#review13092 --- Just retested this with the SVN Asterisk 12 - works well! -

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-15 Thread Jonathan Rose
On Aug. 15, 2014, 4:24 p.m., Krandon Bruse wrote: Just retested this with the SVN Asterisk 12 - works well! I've also written an automated test for this, which can be found here: https://reviewboard.asterisk.org/r/3918/ - Jonathan