Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-09-02 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/ --- (Updated Sept. 2, 2014, 1:17 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-27 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/#review13188 --- Ship it! Ship It!

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/#review13164 --- Review your doxygen because I think you are repeating

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Mark Michelson
On Aug. 25, 2014, 1:12 p.m., Joshua Colp wrote: Review your doxygen because I think you are repeating yourself, and also run through all the PJSIP tests. Do that and this is good to go. I don't see the doxygen problem. One states that on transaction state changes, it is called before SDP

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Joshua Colp
On Aug. 25, 2014, 1:12 p.m., Joshua Colp wrote: Review your doxygen because I think you are repeating yourself, and also run through all the PJSIP tests. Do that and this is good to go. Mark Michelson wrote: I don't see the doxygen problem. One states that on transaction state

[asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24212

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/#review13157 --- My only concern with this is that we somehow have code which

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: My only concern with this is that we somehow have code which expected to be invoked at #3 - do you think this is possible at all? It may also be useful to document your flow discovery above within the code somewhere for future reference.

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Mark Michelson
On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: My only concern with this is that we somehow have code which expected to be invoked at #3 - do you think this is possible at all? Joshua Colp wrote: It may also be useful to document your flow discovery above within the code

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Joshua Colp
On Aug. 24, 2014, 3:56 p.m., Joshua Colp wrote: My only concern with this is that we somehow have code which expected to be invoked at #3 - do you think this is possible at all? Joshua Colp wrote: It may also be useful to document your flow discovery above within the code

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/ --- (Updated Aug. 24, 2014, 11:37 p.m.) Review request for Asterisk