Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 24, 2014, 1:28 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/#review13378 --- Ship it! Ship It! - Joshua Colp On Sept. 19, 2014, 10:02 p.

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 5:02 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 4:55 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 4:54 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 19, 2014, 4:52 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-18 Thread Mark Michelson
> On Sept. 11, 2014, 3:16 p.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, lines 2488-2501 > > > > > > Looking at the pjproject code why wouldn't the following return values > > cover these cases for whe

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-15 Thread rmudgett
> On Sept. 11, 2014, 10:16 a.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, lines 2488-2501 > > > > > > Looking at the pjproject code why wouldn't the following return values > > cover these cases for wh

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/#review13283 --- /branches/13/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 10, 2014, 5:18 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread rmudgett
> On Sept. 10, 2014, 6:51 a.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, lines 2478-2480 > > > > > > I'm hesitant to say that this will always be true. I fear that due to > > the asynchronous nature of

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread rmudgett
> On Sept. 10, 2014, 6:51 a.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, line 2443 > > > > > > unsigned int Sure, if you want. > On Sept. 10, 2014, 6:51 a.m., Joshua Colp wrote: > > /branches/13/res/

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread Joshua Colp
> On Sept. 10, 2014, 11:51 a.m., Joshua Colp wrote: > > /branches/13/res/res_pjsip.c, lines 2478-2480 > > > > > > I'm hesitant to say that this will always be true. I fear that due to > > the asynchronous nature o

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/#review13271 --- /branches/13/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-04 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 4, 2014, 6:41 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-04 Thread rmudgett
> On Sept. 3, 2014, 6:04 p.m., Mark Michelson wrote: > > /branches/13/res/res_pjsip/pjsip_options.c, lines 401-404 > > > > > > I don't understand the race condition you're referring to here since > > the scheduler

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-04 Thread rmudgett
> On Sept. 3, 2014, 6:04 p.m., Mark Michelson wrote: > > /branches/13/res/res_pjsip/pjsip_options.c, lines 401-404 > > > > > > I don't understand the race condition you're referring to here since > > the scheduler

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-03 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/#review13226 --- /branches/13/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-03 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 3, 2014, 9:40 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-09-03 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- (Updated Sept. 3, 2014, 9:31 a.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3954: pjsip_options.c: Fix race condition stopping periodic out of dialog OPTIONS request.

2014-08-28 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3954/ --- Review request for Asterisk Developers. Bugs: AFS-155 https://issues.a