Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread Oron Peled
On Thursday 04 September 2014 11:07:33 David M. Lee wrote: > I don’t have DAHDI support enabled; the Makefile installs it > regardless. I’ll update the patch to only install the script if DAHDI > support is enabled, then. +1 > I have to say that it seems like a bad behavior to install anything >

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/ --- (Updated Sept. 4, 2014, 1:33 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread David M. Lee
On Sep 3, 2014, at 7:15 PM, Oron Peled wrote: > So I don't see a way which would achieve what you want -- i.e: install > as a regular user *and* with DAHDI support. OTOH, build+install of > asterisk *without* DAHDI support should not have this problem (otherwise > it's a bug which should be fixe

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread Shaun Ruffell
> On Sept. 4, 2014, 10:49 a.m., Tzafrir Cohen wrote: > > Short version: not needed, IMO. > > > > The path was hard-coded in the first place because the DAHDI udev hooks > > directory is explicitly hard-coded. Placing it elsewhere does nothing. If > > the prefix is anything other than '/usr'. t

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-04 Thread Tzafrir Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/#review13229 --- Short version: not needed, IMO. The path was hard-coded in the

Re: [asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-03 Thread Oron Peled
Hi, On Wednesday 03 September 2014 13:57:11 David Lee wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3972/ > --- > ... >

[asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

2014-09-03 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3972/ --- Review request for Asterisk Developers. Repository: Asterisk Description