Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- (Updated Sept. 18, 2014, 2:21 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/#review13343 --- Ship it! Ship It! - opticron On Sept. 15, 2014, 2:43 p.m.,

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-15 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- (Updated Sept. 15, 2014, 1:43 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-15 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/#review13305 --- branches/12/include/asterisk/strings.h

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-12 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- (Updated Sept. 12, 2014, 2:04 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/#review13292 --- In general, have a look at coding guidelines violations. In par

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-11 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- (Updated Sept. 12, 2014, 12:12 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-11 Thread George Joseph
> On Sept. 11, 2014, 1:29 p.m., opticron wrote: > > This new string parsing function could use unit tests. Good point. I'll create a test for it. > On Sept. 11, 2014, 1:29 p.m., opticron wrote: > > branches/12/main/utils.c, lines 1483-1486 > >

Re: [asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-11 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/#review13284 --- This new string parsing function could use unit tests. branch

[asterisk-dev] [Code Review] 3989: utils: Create ast_strsep function that ignores separators inside quotes.

2014-09-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3989/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk