Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 19, 2014, 10:10 a.m.) Status -- This change has been m

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13358 --- Ship it! Ship It! - rmudgett On Sept. 18, 2014, 5:50 p.m.,

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 5:50 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13357 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 4:48 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 18, 2014, 3:10 p.m., rmudgett wrote: > > /branches/12/main/stasis_channels.c, lines 381-394 > > > > > > Why is the caller channel lock held for the > > ast_channel_publish_dial_forward() call? > > >

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 18, 2014, 3:10 p.m., rmudgett wrote: > > /branches/12/main/stasis_channels.c, line 1257 > > > > > > dial_masquerade() is called with several locks held: the global > > channels lock, old_chan, and new_c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13345 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13344 --- Ship it! Ship It! - Matt Jordan On Sept. 18, 2014, 1:25 p.m

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 1:25 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13342 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 1:21 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 18, 2014, 12:22 p.m., Matt Jordan wrote: > > /branches/12/main/stasis_channels.c, line 383 > > > > > > This will terminate the dial masquerade datastore on the first dial > > completion message. > >

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 18, 2014, 12:22 p.m., Matt Jordan wrote: > > /branches/12/main/stasis_channels.c, line 383 > > > > > > This will terminate the dial masquerade datastore on the first dial > > completion message. > >

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13339 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 18, 2014, 10:59 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13330 --- /branches/12/main/stasis_channels.c

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- (Updated Sept. 17, 2014, 12:57 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 16, 2014, 12:21 p.m., Matt Jordan wrote: > > /branches/12/main/dial.c, line 1320 > > > > > > Remember that some things are going to want to do a string comparison > > against the type name. Use a more r

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 16, 2014, 12:21 p.m., Matt Jordan wrote: > > /branches/12/main/dial.c, lines 1312-1316 > > > > > > Instead of setting the consume flag, remove the datastore and free it: > > > > if (!ast_channel

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13312 --- /branches/12/include/asterisk/dial.h

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 11, 2014, 5:12 p.m., Jonathan Rose wrote: > > I've got a small change to the above patch that I'm still not sure that is > > appropriate, but it addresses the lack of a dial end for the outgoing dial > > from pjsip/pj123's second channel to pj1603 -- see link below for the > > resul

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

> On Sept. 11, 2014, 5:12 p.m., Jonathan Rose wrote: > > I've got a small change to the above patch that I'm still not sure that is > > appropriate, but it addresses the lack of a dial end for the outgoing dial > > from pjsip/pj123's second channel to pj1603 -- see link below for the > > resul

Re: [asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/#review13287 --- I've got a small change to the above patch that I'm still not s

[asterisk-dev] [Code Review] 3990: CDRs/Dial: Fix an assertion caused by advancing a neutral state channel straight into dial pending without going through dial

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3990/ --- Review request for Asterisk Developers, Matt Jordan and rmudgett. Bugs: AS