Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13687 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

> On Oct. 16, 2014, 9:44 p.m., Mark Michelson wrote: > > /trunk/res/res_pjsip_history.c, lines 44-47 > > > > > > I wonder if the code could be simplified by instead of saving rdata and > > tdata, saving a pjsip_msg

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13555 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

> On Oct. 16, 2014, 11:32 a.m., Joshua Colp wrote: > > /trunk/res/res_pjsip_history.c, line 87 > > > > > > I'm not a fan of these scoped mutexes being here. Despite the enabled > > check being fast you've still got

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

> On Oct. 16, 2014, 6:32 a.m., Joshua Colp wrote: > > /trunk/res/res_pjsip_history.c, line 87 > > > > > > I'm not a fan of these scoped mutexes being here. Despite the enabled > > check being fast you've still got a

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13540 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13516 --- /trunk/res/res_pjsip_history.c

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

> On Oct. 8, 2014, 9:53 a.m., Scott Griepentrog wrote: > > If we were to follow the CLI convention, it would be: > > > > pjsip show histories 4 9 > > > > and > > > > pjsip show history 4 > > > > It might be helpful to also add an alias for 'pjsip show historys' Er... I'm not sure I like th

Re: [asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/#review13467 --- If we were to follow the CLI convention, it would be: pjsip sh

[asterisk-dev] [Code Review] 4053: res_pjsip_history: A debugging module for busy systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4053/ --- Review request for Asterisk Developers. Repository: Asterisk Description