Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-17 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/ --- (Updated Oct. 17, 2014, 8:18 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-16 Thread Joshua Colp
On Oct. 15, 2014, 8:37 p.m., Mark Michelson wrote: /trunk/res/res_pjsip_keepalive.c, lines 151-153 https://reviewboard.asterisk.org/r/4084/diff/1/?file=68351#file68351line151 I'm not very familiar with the PJSIP transport state machine, but I can see that there are two additional

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/ --- (Updated Oct. 16, 2014, 11:24 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-16 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/ --- (Updated Oct. 16, 2014, 2:41 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-16 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/#review13547 --- Ship it! Ship It! - Mark Michelson On Oct. 16, 2014, 2:41

[asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-15 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/#review13527 --- You have red blobs on lines 164, 188, and 271.

Re: [asterisk-dev] [Code Review] 4084: res_pjsip_keepalive: Add keepalive module for connection-oriented transports.

2014-10-15 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4084/#review13532 --- /trunk/res/res_pjsip_keepalive.c