Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- (Updated Nov. 6, 2014, 3:05 a.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

> On Nov. 3, 2014, 1:12 p.m., rmudgett wrote: > > Minor nit. > > > > Does the patch still fix the reporter's memory leak? Mostly, yes (as much as the original patch). I'm not sure it can be fixed completely. I tested with the reporters sip.conf. Each peer originally allocated 2000 bytes fo

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- (Updated Nov. 3, 2014, 1:53 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13658 --- Ship it! Minor nit. Does the patch still fix the reporter's m

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- (Updated Nov. 3, 2014, 12:55 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

> On Oct. 29, 2014, 6:55 p.m., rmudgett wrote: > > 1) In stringfields.h:ast_string_field_ptr_set_by_fields(), the __p__ and > > ptr pointers are the same by initialization so the test for *__p__ != *ptr > > is always false and will not release the old string value when > > __ast_string_field_a

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13656 --- /branches/11/include/asterisk/stringfields.h

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

> On Oct. 29, 2014, 7:55 p.m., rmudgett wrote: > > 1) In stringfields.h:ast_string_field_ptr_set_by_fields(), the __p__ and > > ptr pointers are the same by initialization so the test for *__p__ != *ptr > > is always false and will not release the old string value when > > __ast_string_field_a

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- (Updated Nov. 3, 2014, 8:29 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/#review13628 --- 1) In stringfields.h:ast_string_field_ptr_set_by_fields(), the

[asterisk-dev] [Code Review] 4114: Prevent stringfields from accumulating unused memory

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4114/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24307 https://i