Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-12 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/ --- (Updated Nov. 12, 2014, 7:44 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-09 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/#review13714 --- As part of this change I am adding *.gcno and *.gcna to

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-09 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/#review13715 --- Ship it! Ship It! - wdoekes On Nov. 8, 2014, 6:29 p.m.,

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-08 Thread Corey Farrell
On Nov. 6, 2014, 6:04 a.m., wdoekes wrote: Isn't the better fix to disable coverage for the shadow compilation? Corey Farrell wrote: Probably. I have updated code but I won't have time to test until this weekend. I'll update the review once I've had a chance to do some builds

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-08 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/ --- (Updated Nov. 8, 2014, 1:29 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-07 Thread Matt Jordan
On Nov. 6, 2014, 5:04 a.m., wdoekes wrote: Isn't the better fix to disable coverage for the shadow compilation? Corey Farrell wrote: Probably. I have updated code but I won't have time to test until this weekend. I'll update the review once I've had a chance to do some builds

[asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-06 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24502

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-06 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4151/#review13701 --- Isn't the better fix to disable coverage for the shadow

Re: [asterisk-dev] [Code Review] 4151: Fix compiler error when using ./configure --enable-dev-mode --enable-coverage

2014-11-06 Thread Corey Farrell
On Nov. 6, 2014, 6:04 a.m., wdoekes wrote: Isn't the better fix to disable coverage for the shadow compilation? Probably. I have updated code but I won't have time to test until this weekend. I'll update the review once I've had a chance to do some builds with it. - Corey