Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/ --- (Updated Dec. 15, 2014, 11:07 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/#review13960 --- Ship it! Ship It! - Joshua Colp On Dec. 10, 2014, 11:21 p.m

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/ --- (Updated Dec. 10, 2014, 4:21 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_config_wizard.c, line 746 > > > > > > Is this is successful and last_config exists you may want to just > > remove the category from th

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Dec. 8, 2014, 12:52 p.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_config_wizard.c, line 746 > > > > > > Is this is successful and last_config exists you may want to just > > remove the category from t

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_config_wizard.c, line 746 > > > > > > Is this is successful and last_config exists you may want to just > > remove the category from th

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_config_wizard.c, lines 781-811 > > > > > > This is a roundabout way to do this. > > > > Why not have an API function like apply

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Dec. 8, 2014, 12:52 p.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_config_wizard.c, lines 261-283 > > > > > > While forgiving this would yield an incomplete variable list, causing > > the resulting obj

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Dec. 8, 2014, 5:52 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_config_wizard.c, lines 261-283 > > > > > > While forgiving this would yield an incomplete variable list, causing > > the resulting obje

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/#review13911 --- branches/12/res/res_pjsip_config_wizard.c

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/ --- (Updated Dec. 3, 2014, 4:42 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Dec. 2, 2014, 2:05 p.m., Mark Michelson wrote: > > branches/12/res/res_pjsip_config_wizard.c, lines 631-639 > > > > > > Why are identifies only loaded if accepts_registrations is not true? To > > me, the two a

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/#review13865 --- branches/12/res/res_pjsip_config_wizard.c

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/ --- (Updated Dec. 1, 2014, 5:40 p.m.) Review request for Asterisk Developers,

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Nov. 24, 2014, 3:47 p.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_config_wizard.c, line 295 > > > > > > A question: > > > > If stuff starts falling apart and we run out of memory - how will al

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

> On Nov. 24, 2014, 8:47 a.m., Joshua Colp wrote: > > branches/12/configs/pjsip_wizard.conf.sample, lines 46-47 > > > > > > This may or may not be true - specifically requiring 2 registrations. > > It's an implement

Re: [asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/#review13845 --- branches/12/configs/pjsip_wizard.conf.sample

[asterisk-dev] [Code Review] 4190: res_pjsip_config_wizard: Allow streamlined configuration of common pjsip scenarios

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4190/ --- Review request for Asterisk Developers, Joshua Colp and Mark Michelson. Re