Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2015-01-09 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/ --- (Updated Jan. 9, 2015, 4:09 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review14132 --- Ship it! Ship It! - Mark Michelson On Dec. 31, 2014, 6:13 p

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/ --- (Updated Dec. 31, 2014, 12:13 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/ --- (Updated Dec. 31, 2014, 9:10 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-31 Thread Scott Griepentrog
> On Dec. 23, 2014, 9:18 a.m., Matt Jordan wrote: > > /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py, lines 334-335 > > > > > > This could be written as: > > > > res.extend([inc.get_sections(k

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-23 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review14033 --- /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py <

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/ --- (Updated Dec. 19, 2014, 7:52 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-19 Thread Scott Griepentrog
> On Dec. 17, 2014, 2:08 p.m., Mark Michelson wrote: > > /branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py, lines 590-594 > > > > > > I don't agree with this change. While I expect it to be rare, if > > som

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-18 Thread Kevin Harwell
> On Dec. 18, 2014, 11:39 a.m., Kevin Harwell wrote: > > /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py, lines 333-335 > > > > > > I believe sections can be defined across multiple includes. Removing

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-18 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review14008 --- /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py <

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-17 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review13995 --- /branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py

[asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-17 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24474 https://i