[asterisk-dev] [Code Review] 4288: res_pjsip_phoneprovi_provider: Fix reload

2014-12-21 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4288/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4288: res_pjsip_phoneprovi_provider: Fix reload

2014-12-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4288/#review14022 --- branches/13/res/res_pjsip_phoneprov_provider.c

Re: [asterisk-dev] [Code Review] 4288: res_pjsip_phoneprovi_provider: Fix reload

2014-12-21 Thread George Joseph
On Dec. 21, 2014, 3:58 p.m., Joshua Colp wrote: branches/13/res/res_pjsip_phoneprov_provider.c, line 357 https://reviewboard.asterisk.org/r/4288/diff/1/?file=69974#file69974line357 Why are you using this instead of a retrieve_by_fields and AST_RETRIEVE_FLAG_MULTIPLE |

Re: [asterisk-dev] [Code Review] 4288: res_pjsip_phoneprovi_provider: Fix reload

2014-12-21 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4288/ --- (Updated Dec. 21, 2014, 5 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4288: res_pjsip_phoneprovi_provider: Fix reload

2014-12-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4288/#review14024 --- Ship it! Ship It! - Joshua Colp On Dec. 22, 2014,

Re: [asterisk-dev] [Code Review] 4288: res_pjsip_phoneprovi_provider: Fix reload

2014-12-21 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4288/ --- (Updated Dec. 21, 2014, 6:17 p.m.) Status -- This change has been