Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-08 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/ --- (Updated Jan. 8, 2015, 3:38 p.m.) Status -- This change has been mark

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/#review14129 --- Ship it! Ship It! - Mark Michelson On Jan. 5, 2015, 11:33 p

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/ --- (Updated Jan. 5, 2015, 4:33 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-05 Thread George Joseph
> On Jan. 5, 2015, 2:37 p.m., Mark Michelson wrote: > > branches/13/res/res_pjsip_outbound_registration.c, lines 416-420 > > > > > > So, this code change is "correct" in the sense that it is getting rid > > of an e

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/#review14075 --- branches/13/res/res_pjsip_outbound_registration.c

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-02 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/ --- (Updated Jan. 2, 2015, 7:04 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2015-01-02 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/#review14070 --- Actually, response->client_state *should* be being unreffed (se

[asterisk-dev] [Code Review] 4303: res_pjsip_outbound_registration: Fix reference leak.

2014-12-30 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4303/ --- Review request for Asterisk Developers. Repository: Asterisk Description