Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 13, 2015, 12:28 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/#review14459 --- Ship it! Ship It! - Mark Michelson On Feb. 13, 2015, 3:48 p

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 13, 2015, 9:48 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

> On Feb. 12, 2015, 12:42 p.m., Mark Michelson wrote: > > /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, lines 258-259 > > > > > > Is this change necessary since you ended up overriding reg_success() in > > your

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

> On Feb. 12, 2015, 6:42 p.m., Mark Michelson wrote: > > /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, lines 258-259 > > > > > > Is this change necessary since you ended up overriding reg_success() in > > your

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 6:27 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

> On Feb. 12, 2015, 12:42 p.m., Mark Michelson wrote: > > /asterisk/trunk/lib/python/asterisk/phones.py, lines 86-88 > > > > > > I think this is a good case for using "is" instead of equality. I > > imagine that cal

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/#review14450 --- /asterisk/trunk/lib/python/asterisk/phones.py

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 10:25 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 11, 2015, 12:32 a.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- Review request for Asterisk Developers. Repository: testsuite Descriptio