Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/#review14554 --- Ship it! Ship It! - Joshua Colp On Feb. 20, 2015, 2:59

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/ --- (Updated Feb. 25, 2015, 3:49 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-20 Thread Mark Michelson
On Feb. 18, 2015, 8:58 p.m., Mark Michelson wrote: /asterisk/trunk/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/test-config.yaml, lines 10-13 https://reviewboard.asterisk.org/r/4420/diff/1/?file=71429#file71429line10 I think that the lifetime checks should include the bottom

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-19 Thread Matt Jordan
On Feb. 18, 2015, 2:58 p.m., Mark Michelson wrote: /asterisk/trunk/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_nominal.csv, lines 7-8 https://reviewboard.asterisk.org/r/4420/diff/1/?file=71424#file71424line7 I have no idea what difference this

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/ --- (Updated Feb. 19, 2015, 8:59 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/#review14489 --- Comments regarding recommended test cases for the chan_sip

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-18 Thread Mark Michelson
On Feb. 18, 2015, 8:58 p.m., Mark Michelson wrote: /asterisk/trunk/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/srtp-invite-double-crypto.xml, line 49 https://reviewboard.asterisk.org/r/4420/diff/1/?file=71426#file71426line49 The regex being used here has some issues.

[asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/ --- Review request for Asterisk Developers and Olle E Johansson. Bugs: