Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r// --- (Updated March 6, 2015, 1:52 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r//#review14593 --- Ship it! Problems with CID detection resolved by swapping out

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r// --- (Updated March 2, 2015, 3:18 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

> On Feb. 27, 2015, 9:39 a.m., Scott Griepentrog wrote: > > I updated the chan_dahdi [channels] configuration with cadences matching > > the Bellcore spec and retested for both CID detection and DR pattern > > recognition. Results are certain patterns (especially DR2, DR4, and DR5) > > exhibi

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r//#review14562 --- I updated the chan_dahdi [channels] configuration with cadences

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

> On Feb. 27, 2015, 9:39 a.m., Scott Griepentrog wrote: > > I updated the chan_dahdi [channels] configuration with cadences matching > > the Bellcore spec and retested for both CID detection and DR pattern > > recognition. Results are certain patterns (especially DR2, DR4, and DR5) > > exhibi

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

> On Feb. 24, 2015, 5:35 p.m., Kevin Harwell wrote: > > /branches/11/channels/chan_dahdi.c, lines 1965-1967 > > > > > > Since you rearranged the 'ring - range' check should it be '<' instead > > of '<='? Otherwise

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

> On Feb. 24, 2015, 5:19 p.m., Matt Jordan wrote: > > /branches/11/channels/chan_dahdi.c, line 1914 > > > > > > Nitpick: while you're cleaning this area up, spaces around '/' would be > > nice: > > > > if

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

> On Feb. 24, 2015, 5:35 p.m., Kevin Harwell wrote: > > /branches/11/channels/chan_dahdi.c, lines 1965-1967 > > > > > > Since you rearranged the 'ring - range' check should it be '<' instead > > of '<='? Otherwise

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r//#review14538 --- /branches/11/channels/chan_dahdi.c

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r//#review14537 --- Assuming Scott's testing goes well, I'll click the Ship It! but

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r//#review14533 --- Tested with a looped tdm board generating various DR patterns a

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r// --- (Updated Feb. 23, 2015, 6:51 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r// --- Review request for Asterisk Developers. Bugs: ASTERISK-24825 https://i