Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-04-09 Thread Dmitriy Serov
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4476/ --- (Updated April 9, 2015, 1:02 p.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-25 Thread Joshua Colp
> On March 24, 2015, 3:39 p.m., Mark Michelson wrote: > > I'm not a big fan of this module for a couple of reasons: > > > > 1) The data in the request URI is intended to describe who the call is > > destined to be sent to, not who the call originated from. There are systems > > out there where

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-24 Thread Dmitriy Serov
> On March 24, 2015, 3:39 p.m., Mark Michelson wrote: > > I'm not a big fan of this module for a couple of reasons: > > > > 1) The data in the request URI is intended to describe who the call is > > destined to be sent to, not who the call originated from. There are systems > > out there where

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-24 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4476/#review14793 --- I'm not a big fan of this module for a couple of reasons: 1) T

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-24 Thread Dmitriy Serov
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4476/ --- (Updated March 24, 2015, 12:23 p.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4476/#review14782 --- /trunk/res/res_pjsip_endpoint_identifier_request_user.c

Re: [asterisk-dev] [Code Review] 4476: new res_pjsip module to identify endpoint for an incoming call with a trunk that has outbound registration.

2015-03-11 Thread Dmitriy Serov
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4476/ --- (Updated March 11, 2015, 4:30 p.m.) Review request for Asterisk Developers