Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-16 Thread Jeffrey Ollie
On Wed, Apr 15, 2015 at 2:11 PM, Mark Michelson mmichel...@digium.com wrote: On 04/14/2015 12:11 PM, Matthew Jordan wrote: The question is: is this change worth having, or should it be scrapped in favour of some alternate approach that makes use of other technology? My feelings won't be

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-16 Thread Brad Watkins
This is definitely the approach that I would prefer as well, as it makes integration with external software much easier. - Brad On Thu, Apr 16, 2015 at 12:37 PM, Jeffrey Ollie j...@ocjtech.us wrote: On Wed, Apr 15, 2015 at 2:11 PM, Mark Michelson mmichel...@digium.com wrote: On 04/14/2015

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-15 Thread Mark Michelson
On 04/14/2015 12:11 PM, Matthew Jordan wrote: snip Yup. SO! The question is: is this change worth having, or should it be scrapped in favour of some alternate approach that makes use of other technology? My feelings won't be hurt if the answer is ditch it and do something else - this was a fun

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-14 Thread Matthew Jordan
On Wed, Apr 8, 2015 at 1:03 PM, Mark Michelson reviewbo...@asterisk.org wrote: Before I repost the AstDB Clustering review from Review Board onto Gerrit, I wanted to address Mark's concerns below. Depending on what people think, it may be worth just shelving the idea. The only things I can

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4490/#review15135 --- The only things I can think of that are issues here are based

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-04-05 Thread Matt Jordan
On April 2, 2015, 2:41 p.m., Mark Michelson wrote: /trunk/main/db.c, lines 958-977 https://reviewboard.asterisk.org/r/4490/diff/2/?file=73358#file73358line958 The dialplan function allows an omitted type to automatically be interpreted as global but the CLI command requires that

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-03-28 Thread Matt Jordan
On March 25, 2015, 5:26 p.m., rmudgett wrote: /trunk/main/db.c, lines 493-497 https://reviewboard.asterisk.org/r/4490/diff/1/?file=72613#file72613line493 Is clone ref leaked here? Yup. I had initially used RAII_VAR here, and didn't complete the removal. Thanks for catching that.

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-03-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4490/ --- (Updated March 25, 2015, 10:35 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-03-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4490/#review14836 --- /trunk/funcs/func_db.c

[asterisk-dev] [Code Review] 4490: astdb: Allow clustering of the Asterisk Database between multiple Asterisk servers

2015-03-17 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4490/ --- Review request for Asterisk Developers. Repository: Asterisk