Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-27 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/ --- (Updated March 27, 2015, 5:25 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-24 Thread rnewton
> On March 24, 2015, 10:32 p.m., rnewton wrote: > > Tested with 4488. Pretty much worked fine. > > > > You will need to add a timing interface to modules.conf. > > res_timing_timerfd.so is probably fine. When testing with 4488 I ran through the following tests: *patch1 - internal stuff* inter

Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-24 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/#review14822 --- /branches/13/configs/basic-pbx/extensions.conf

Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-24 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/#review14821 --- Tested with 4488. Pretty much worked fine. You will need to ad

Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-19 Thread rnewton
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/#review14741 --- Looks good. I'm finally testing with these with outside connect

Re: [asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-17 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/#review14715 --- Ship it! Ship It! - Joshua Colp On March 16, 2015, 5:48 p.m

[asterisk-dev] [Code Review] 4504: SAC: Add conferences for employees / employees+customers

2015-03-16 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4504/ --- Review request for Asterisk Developers and rnewton. Repository: Asterisk