Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- (Updated April 6, 2015, 1:03 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/#review14980 --- Ship it! Ship It! - Mark Michelson On March 28, 2015, 3:08

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- (Updated March 28, 2015, 4:08 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:23 p.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 8:23 a.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:23 p.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 8:23 a.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:23 p.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, lines 960-961 > > > > > > Well, this won't quite work, as appdata can be NULL. strlen isn't NULL > > safe. > > > > As s

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- (Updated March 27, 2015, 5:32 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/#review14894 --- /branches/13/pbx/pbx_config.c

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:11 a.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, line 977 > > > > > > So, dup'ing things on the stack here in a nested loop is actually quite > > dangerous. Unlike a local varia

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- (Updated March 27, 2015, 11:22 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

> On March 27, 2015, 2:11 a.m., Matt Jordan wrote: > > /branches/13/pbx/pbx_config.c, line 977 > > > > > > So, dup'ing things on the stack here in a nested loop is actually quite > > dangerous. Unlike a local varia

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/#review14874 --- /branches/13/pbx/pbx_config.c

[asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i