Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/ --- (Updated April 7, 2015, 10:21 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/#review15065 --- Ship it! Ship It! - Joshua Colp On April 6, 2015, 2:39 a.m.

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/ --- (Updated April 5, 2015, 9:39 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

> On March 31, 2015, 8:21 a.m., Joshua Colp wrote: > > /branches/13/res/stasis/control.c, lines 609-622 > > > > > > This is substantially changing the behavior. > > > > ast_indicate will tell the channel to

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

> On March 31, 2015, 12:23 p.m., Mark Michelson wrote: > > One thing to take into consideration here is that there are some places > > within Asterisk where we will send an AST_CONTROL_UNHOLD frame on a > > channel, even though it may not currently be on hold. This means you may > > send some

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

> On March 31, 2015, 5:23 p.m., Mark Michelson wrote: > > One thing to take into consideration here is that there are some places > > within Asterisk where we will send an AST_CONTROL_UNHOLD frame on a > > channel, even though it may not currently be on hold. This means you may > > send some u

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

> On March 31, 2015, 12:23 p.m., Mark Michelson wrote: > > One thing to take into consideration here is that there are some places > > within Asterisk where we will send an AST_CONTROL_UNHOLD frame on a > > channel, even though it may not currently be on hold. This means you may > > send some

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/#review14988 --- One thing to take into consideration here is that there are som

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/#review14967 --- /branches/13/funcs/func_holdintercept.c

[asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/ --- Review request for Asterisk Developers and Joshua Colp. Bugs: ASTERISK-249