Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/ --- (Updated April 18, 2015, 1:29 p.m.) Status -- This change has been di

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 4, 2015, 12:40 a.m., rmudgett wrote: > > /branches/13/channels/chan_iax2.c, lines 2009-2013 > > > > > > This change causes bugs. It is supposed to return peer because it > > increased the ref. > > Die

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 3, 2015, 5:40 p.m., rmudgett wrote: > > /branches/13/channels/chan_iax2.c, lines 2009-2013 > > > > > > This change causes bugs. It is supposed to return peer because it > > increased the ref. > > Died

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 3, 2015, 11:36 p.m., rmudgett wrote: > > This is still a nuisance warning that doesn't add much value for the effort. > > Diederik de Groot wrote: > We can drop it no problem. I still think it could be useful in detecting > _ref/_unref issues, alas it would quite a bit of work bu

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 4, 2015, 12:40 a.m., rmudgett wrote: > > /branches/13/channels/chan_iax2.c, lines 2009-2013 > > > > > > This change causes bugs. It is supposed to return peer because it > > increased the ref. Stupid

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/ --- (Updated April 4, 2015, 1:15 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 3, 2015, 4:36 p.m., rmudgett wrote: > > This is still a nuisance warning that doesn't add much value for the effort. > > Diederik de Groot wrote: > We can drop it no problem. I still think it could be useful in detecting > _ref/_unref issues, alas it would quite a bit of work but

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/#review15053 --- /branches/13/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 3, 2015, 11:36 p.m., rmudgett wrote: > > This is still a nuisance warning that doesn't add much value for the effort. > > Diederik de Groot wrote: > We can drop it no problem. I still think it could be useful in detecting > _ref/_unref issues, alas it would quite a bit of work bu

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 3, 2015, 11:36 p.m., rmudgett wrote: > > This is still a nuisance warning that doesn't add much value for the effort. We can drop it no problem. I still think it could be useful in detecting _ref/_unref issues, alas it would quite a bit of work but could be beneficial. If there is c

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/#review15049 --- This is still a nuisance warning that doesn't add much value fo

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/ --- (Updated April 3, 2015, 11:24 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On April 1, 2015, 12:30 a.m., rmudgett wrote: > > I dislike this warning. It is more nuisance than helpful. I once worked > > with compiler that had a similar warning. The lengths you sometimes have > > to go to eradicate the the warning can be extream. > > > > There are several places in

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/#review14999 --- I dislike this warning. It is more nuisance than helpful. I o

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

> On March 29, 2015, 1:49 a.m., Diederik de Groot wrote: > > The fixes for unused-value to chan_iax2, to compile smoothly should be seen as a showcase that this can be off potential benefit. Would have been nice if ao2_ref(..., -1) would have behaved in the same way, so that ao2_ref(..., -1)

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/#review14952 --- /branches/13/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/ --- (Updated March 29, 2015, 1:44 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/ --- (Updated March 29, 2015, 12:46 a.m.) Review request for Asterisk Developer

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/#review14951 --- Work in Progress: There are too many sources issues with "-Wunu

Re: [asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/ --- (Updated March 28, 2015, 8:32 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4554: clang compiler warning: -Wunused-value

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4554/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917 https://i