Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-04-08 Thread Valentin Vidić
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/ --- (Updated April 8, 2015, 6:53 a.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-04-07 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/#review15110 --- Did this really apply to all operating systems and all versions

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-04-07 Thread Michael Young
> On March 31, 2015, 11:19 a.m., Michael Young wrote: > > I would hold off on committing this patch as I feel it is not really a > > proper solution. I believe that this is just short circuiting the > > conditional and always applying remapping if IPv6 is involved or not. On > > the issue tr

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-03-31 Thread Joshua Colp
> On March 31, 2015, 3:19 p.m., Michael Young wrote: > > I would hold off on committing this patch as I feel it is not really a > > proper solution. I believe that this is just short circuiting the > > conditional and always applying remapping if IPv6 is involved or not. On > > the issue tra

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-03-31 Thread Joshua Colp
> On March 31, 2015, 3:19 p.m., Michael Young wrote: > > I would hold off on committing this patch as I feel it is not really a > > proper solution. I believe that this is just short circuiting the > > conditional and always applying remapping if IPv6 is involved or not. On > > the issue tra

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-03-31 Thread Michael Young
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/#review14973 --- I would hold off on committing this patch as I feel it is not r

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-03-31 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/#review14970 --- Ship it! Ship It! - Joshua Colp On March 30, 2015, 2:23 p.m

Re: [asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-03-30 Thread Valentin Vidić
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/ --- (Updated March 30, 2015, 2:23 p.m.) Review request for Asterisk Developers

[asterisk-dev] [Code Review] 4563: chan_sip: handle IPv4 mapped clients when NAT and IPv6 socket is enabled

2015-03-30 Thread Valentin Vidić
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4563/ --- Review request for Asterisk Developers. Bugs: ASTERISK-18032 https://i