Re: [asterisk-dev] [Code Review] 4594: Asterisk manager output escape message control characters

2015-04-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4594/#review15129 --- I have a few problems with this review: * I don't see in this

Re: [asterisk-dev] [Code Review] 4594: Asterisk manager output escape message control characters

2015-04-08 Thread warren smith
On April 8, 2015, 5:05 p.m., Mark Michelson wrote: I have a few problems with this review: * I don't see in this review or in the patch you uploaded to the linked issue where ast_escape_c() or astman_escape_output() are defined. * This patch performs a lot of heap allocations and

Re: [asterisk-dev] [Code Review] 4594: Asterisk manager output escape message control characters

2015-04-08 Thread warren smith
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4594/ --- (Updated April 8, 2015, 5:51 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4594: Asterisk manager output escape message control characters

2015-04-07 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4594/#review15099 --- I don't see the actual patch on the issue. Did you use

Re: [asterisk-dev] [Code Review] 4594: Asterisk manager output escape message control characters

2015-04-07 Thread warren smith
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4594/ --- (Updated April 7, 2015, 6:25 p.m.) Review request for Asterisk