Re: [asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

2015-04-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/ --- (Updated April 9, 2015, 10:50 a.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

2015-04-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/#review15131 --- Ship it! Ship It! - Joshua Colp On April 7, 2015, 5:49 p.m.

Re: [asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

2015-04-07 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/#review15116 --- Ship it! /trunk/main/dns_test.c

Re: [asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

2015-04-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/ --- (Updated April 7, 2015, 5:49 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

2015-04-07 Thread Mark Michelson
> On April 7, 2015, 5:28 p.m., Kevin Harwell wrote: > > /trunk/main/dns_core.c, line 438 > > > > > > No value is set on true. This is intended. See https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html - Mark -

Re: [asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

2015-04-07 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/#review15092 --- /team/group/dns/main/dns_test.c

[asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

2015-04-06 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/ --- Review request for Asterisk Developers. Repository: Asterisk Description