Re: [asterisk-dev] [asterisk-commits] qwell: trunk r82800 - in /trunk: apps/app_queue.c configs/queues.conf.sample

2007-09-18 Thread Kevin P. Fleming
Mark Michelson wrote: > I just checked, and in 1.4 and trunk, static members, realtime members, > manager-added members, CLI-added members, and dialplan-added members > will all have their membername set to their interface if no membername > is specified. Yep, I see that now. I'd prefer it be

Re: [asterisk-dev] [asterisk-commits] qwell: trunk r82800 - in /trunk: apps/app_queue.c configs/queues.conf.sample

2007-09-18 Thread Kevin P. Fleming
Mark Michelson wrote: > Correct me if I'm wrong, but I believe that the membername field of a > member will be set to it's interface if no name is specified. There may > be some exception, but I'm pretty certain this happens for all types of > members. I was just working in that code yesterday

Re: [asterisk-dev] [asterisk-commits] qwell: trunk r82800 - in /trunk: apps/app_queue.c configs/queues.conf.sample

2007-09-18 Thread Mark Michelson
Mark Michelson wrote: > Kevin P. Fleming wrote: > >> SVN commits to the Asterisk project wrote: >> >> >> >>> + if (update_cdr && qe->chan->cdr) >>> + ast_copy_string(qe->chan->cdr->dstchannel, >>> member->membername, sizeof(qe->chan->cdr->dstchannel)); >>>

Re: [asterisk-dev] [asterisk-commits] qwell: trunk r82800 - in /trunk: apps/app_queue.c configs/queues.conf.sample

2007-09-18 Thread Mark Michelson
Kevin P. Fleming wrote: > SVN commits to the Asterisk project wrote: > > >> +if (update_cdr && qe->chan->cdr) >> +ast_copy_string(qe->chan->cdr->dstchannel, >> member->membername, sizeof(qe->chan->cdr->dstchannel)); >> > > This is buggy; member->membername

Re: [asterisk-dev] [asterisk-commits] qwell: trunk r82800 - in /trunk: apps/app_queue.c configs/queues.conf.sample

2007-09-18 Thread Kevin P. Fleming
SVN commits to the Asterisk project wrote: > + if (update_cdr && qe->chan->cdr) > + ast_copy_string(qe->chan->cdr->dstchannel, > member->membername, sizeof(qe->chan->cdr->dstchannel)); This is buggy; member->membername could be an empty string, it is only populat