Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Olle E. Johansson
On 07 Jan 2014, at 15:55, SVN commits to the Digium repositories svn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg, PJSIP_H_CONTACT, NULL)) - (PJSIP_URI_SCHEME_IS_SIP(contact-uri) ||

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Joshua Colp
Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositoriessvn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg, PJSIP_H_CONTACT, NULL)) - (PJSIP_URI_SCHEME_IS_SIP(contact-uri) ||

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Matthew Jordan
On Tue, Jan 7, 2014 at 9:27 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositoriessvn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg,

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Daniel Jenkins
On Tue, Jan 7, 2014 at 5:03 PM, Matthew Jordan mjor...@digium.com wrote: On Tue, Jan 7, 2014 at 9:27 AM, Joshua Colp jc...@digium.com wrote: Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositoriessvn-comm...@lists.digium.com wrote: if

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Paul Belanger
On 14-01-07 10:10 AM, Olle E. Johansson wrote: On 07 Jan 2014, at 15:55, SVN commits to the Digium repositories svn-comm...@lists.digium.com wrote: if (endpoint-nat.rewrite_contact (contact = pjsip_msg_find_hdr(rdata-msg_info.msg, PJSIP_H_CONTACT, NULL)) -

Re: [asterisk-dev] [svn-commits] file: branch 12 r405019 - /branches/12/res/res_pjsip_nat.c

2014-01-07 Thread Joshua Colp
Paul Belanger wrote: IMO, these are also perfect candidates for parsing unit tests. It would have been great to also see us add something to better increase out code coverage. PJSIP has unit tests already which covers the URI parser. I just did a rough count and there's 39 different ones.