Re: [asterisk-dev] A Week with GIT/Gerrit

2015-04-20 Thread Matthew Jordan
On Sat, Apr 18, 2015 at 8:26 PM, Matthew Jordan mjor...@digium.com wrote: On Thu, Apr 16, 2015 at 5:00 PM, George Joseph george.jos...@fairview5.com wrote: The Emails: Overall I think they're too verbose. Change in asterisk[master]: bridge.c: NULL app causes crash during attended transfer

Re: [asterisk-dev] A Week with GIT/Gerrit

2015-04-20 Thread Matthew Jordan
On Fri, Apr 17, 2015 at 3:42 PM, Corey Farrell g...@cfware.com wrote: My additions to the list: 1) Procedure for 'git review' of security related patches. I think this could be done with an asterisk-security mirror repository setup in gerrit with restricted access. I know this is already

Re: [asterisk-dev] A Week with GIT/Gerrit

2015-04-18 Thread Matthew Jordan
On Thu, Apr 16, 2015 at 5:00 PM, George Joseph george.jos...@fairview5.com wrote: The Emails: Overall I think they're too verbose. Change in asterisk[master]: bridge.c: NULL app causes crash during attended transfer might be better as bridge.c: NULL app causes crash during attended

Re: [asterisk-dev] A Week with GIT/Gerrit

2015-04-17 Thread Corey Farrell
My additions to the list: 1) Procedure for 'git review' of security related patches. I think this could be done with an asterisk-security mirror repository setup in gerrit with restricted access. I know this is already being thought about, just wanted to make sure it on the list. 2) Is there a

[asterisk-dev] A Week with GIT/Gerrit

2015-04-16 Thread George Joseph
The Emails: Overall I think they're too verbose. Change in asterisk[master]: bridge.c: NULL app causes crash during attended transfer might be better as bridge.c: NULL app causes crash during attended transfer (asterisk[master]) It's not a lot shorter but it has the most valuable info at the

Re: [asterisk-dev] A Week with GIT/Gerrit

2015-04-16 Thread Russell Bryant
On Thu, Apr 16, 2015 at 6:00 PM, George Joseph george.jos...@fairview5.com wrote: Something I've noticed though is that dependencies get messed up when cherry-picking a series of dependent patches. Look at my patches 46, 47, 48 for master. If I cherry-pick 48 to my local repo, I get all 3

Re: [asterisk-dev] A Week with GIT/Gerrit

2015-04-16 Thread George Joseph
On Thu, Apr 16, 2015 at 4:11 PM, Russell Bryant russ...@russellbryant.net wrote: On Thu, Apr 16, 2015 at 6:00 PM, George Joseph george.jos...@fairview5.com wrote: Something I've noticed though is that dependencies get messed up when cherry-picking a series of dependent patches. Look at my