Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-11-07 Thread Sébastien Duthil
On 21/10/16 10:21 AM, Mark Michelson wrote: > I have opened https://issues.asterisk.org/jira/browse/ASTERISK-26492 > and have attached the patch there. Feel free to try it out and let me > know on the issue how it works for you. I've played around with your patch, and it works very well. Thanks fo

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-21 Thread Corey Farrell
On Fri, Oct 21, 2016 at 12:32 PM, Kevin Harwell wrote: > On Fri, Oct 21, 2016 at 10:49 AM, Corey Farrell wrote: >> >> >> I'm in favor per app config. I do not yet use ARI, but when I do I >> will have '#tryinclude /etc/asterisk/ari.d/*.conf' in ari.conf. My >> hope is that each ARI app would in

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-21 Thread Kevin Harwell
On Fri, Oct 21, 2016 at 10:49 AM, Corey Farrell wrote: > > I'm in favor per app config. I do not yet use ARI, but when I do I > will have '#tryinclude /etc/asterisk/ari.d/*.conf' in ari.conf. My > hope is that each ARI app would install it's own config to > /etc/asterisk/ari.d, avoid modificati

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-21 Thread Corey Farrell
On Fri, Oct 21, 2016 at 9:37 AM, Sébastien Duthil wrote: > On 19/10/16 11:59 AM, Mark Michelson wrote: >> I had thought about making the list of channel variables per-ARI app >> instead of global, but I don't know if that's actually desired. > > The underlining question would be: do people use

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-21 Thread Mark Michelson
I have opened https://issues.asterisk.org/jira/browse/ASTERISK-26492 and have attached the patch there. Feel free to try it out and let me know on the issue how it works for you. On Fri, Oct 21, 2016 at 8:37 AM, Sébastien Duthil wrote: > On 19/10/16 11:59 AM, Mark Michelson wrote: > > I actually

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-21 Thread Sébastien Duthil
On 19/10/16 11:59 AM, Mark Michelson wrote: > I actually have a patch I've written locally in my spare time that > adds an ari.conf option called "channelvars" that works exactly the > same as for manager.conf. In other words, it modifies channel > snapshots to have the channel variables specified

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-19 Thread Sébastien Duthil
On 18/10/16 10:13 AM, Matt Fredrickson wrote: > *snip* > Your proposal sounds reasonable to me - that is to say, I can't see anything > wrong with adding that behavior. > *snip* Great! On 19/10/16 07:45 AM, Matthew Jordan wrote: > Two thoughts: > (1) I wonder if anyone needs the state conveyed

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-19 Thread Mark Michelson
On 10/19/2016 06:45 AM, Matthew Jordan wrote: On Tue, Oct 18, 2016 at 4:02 PM, Joshua Colp wrote: Matthew Jordan wrote: There are a few wrinkles with emitting channel variables with arbitrary events (of which StasisEnd would qualify). When an event is emitted out of the APIs, it's typical

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-19 Thread Joshua Colp
Matthew Jordan wrote: Two thoughts: (1) I wonder if anyone needs the state conveyed on events other than StasisEnd? If Asterisk is maintaining all of your state for you, and you need to know some part of the state in your external application, how do you ask for it? (2) Even if we emit varia

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-19 Thread Matthew Jordan
On Tue, Oct 18, 2016 at 4:02 PM, Joshua Colp wrote: > Matthew Jordan wrote: > > > > >> There are a few wrinkles with emitting channel variables with >> arbitrary events (of which StasisEnd would qualify). >> >> When an event is emitted out of the APIs, it's typically being done so >> as a result

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-18 Thread Joshua Colp
Matthew Jordan wrote: There are a few wrinkles with emitting channel variables with arbitrary events (of which StasisEnd would qualify). When an event is emitted out of the APIs, it's typically being done so as a result of a message having been published on the Stasis message bus. The message

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-18 Thread Matthew Jordan
On Tue, Oct 18, 2016 at 9:26 AM, Joshua Colp wrote: > Matt Fredrickson wrote: > > > >> >> First off, sorry about the delayed response. Your proposal sounds >> reasonable to me - that is to say, I can't see anything wrong with >> adding that behavior. Perhaps making channel variable dumping on >

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-18 Thread Joshua Colp
Matt Fredrickson wrote: First off, sorry about the delayed response. Your proposal sounds reasonable to me - that is to say, I can't see anything wrong with adding that behavior. Perhaps making channel variable dumping on StasisEnd optional instead of mandatory would be better, but other th

Re: [asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-18 Thread Matt Fredrickson
Thoughts below. On Tue, Oct 11, 2016 at 2:04 PM, Sébastien Duthil wrote: > Hi everyone, > > Sylvain Boily and I gave a talk during Astridevcon 2016 about our usage > of ARI in the XiVO project [1]. We'd like to discuss some of the issues > we encountered, to see if other people have had similar i

[asterisk-dev] ARI StasisEnd event vs. channel variables

2016-10-11 Thread Sébastien Duthil
Hi everyone, Sylvain Boily and I gave a talk during Astridevcon 2016 about our usage of ARI in the XiVO project [1]. We'd like to discuss some of the issues we encountered, to see if other people have had similar issues, and how we could address them. We'll stick to one issue per thread. Current