Re: [asterisk-dev] acl.c - option to turn off logging

2019-12-05 Thread Jaco Kroon
Hi Kevin, Joshua, Your opinions on https://gerrit.asterisk.org/c/asterisk/+/13370 would be greatly appreciated. I ended up doing a combination of the described by creating and _internal variant, where purpose basically becomes log_prefix ... and if that's supplied it enables logging. There are

Re: [asterisk-dev] acl.c - option to turn off logging

2019-12-04 Thread Kevin Harwell
On Wed, Dec 4, 2019 at 5:05 AM Joshua C. Colp wrote: > On Wed, Dec 4, 2019 at 5:05 AM Jaco Kroon wrote: > >> Hi All, >> >> In ast_apply_acl (main/acl.c) there is two lines that's issuing a >> LOG_WARNING when an ACL gets denied. >> >> The first happens if the ACL is invalid. I'm not too

Re: [asterisk-dev] acl.c - option to turn off logging

2019-12-04 Thread Joshua C. Colp
On Wed, Dec 4, 2019 at 5:05 AM Jaco Kroon wrote: > Hi All, > > In ast_apply_acl (main/acl.c) there is two lines that's issuing a > LOG_WARNING when an ACL gets denied. > > The first happens if the ACL is invalid. I'm not too worried about this > specific one, it's probably a good thing if this

[asterisk-dev] acl.c - option to turn off logging

2019-12-04 Thread Jaco Kroon
Hi All, In ast_apply_acl (main/acl.c) there is two lines that's issuing a LOG_WARNING when an ACL gets denied. The first happens if the ACL is invalid.  I'm not too worried about this specific one, it's probably a good thing if this gets logged always. The latter, in the case of AST_SENSE_DENY