Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add virtual line support for automatic inbound matching

2014-01-16 Thread Joshua Colp
://reviewboard.asterisk.org/r/2964/diff/ Testing --- Registered to an ITSP, placed an inbound call from them, confirmed matched using line parameter. Registered to a chan_sip instance, placed an inbound call from it, confirmed matched using line parameter. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3139: chan_pjsip: Test that all configured codecs are present in INVITE when sending

2014-01-18 Thread Joshua Colp
. Without patch that fixes issue it failed, with patch it passes. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] [Code Review] 3140: chan_pjsip: Send configured codecs even when core requests a specific one

2014-01-18 Thread Joshua Colp
in the SDP. Diffs - /branches/12/res/res_pjsip_session.c 405776 Diff: https://reviewboard.asterisk.org/r/3140/diff/ Testing --- Placed calls, confirmed that configured codecs are being sent now. Ran test and confirmed it passes with change. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

2014-01-21 Thread Joshua Colp
/attended_transfer/attended_transfer.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3145/diff/ Testing --- Ran test, fails using branches. Applied patch for events and it passes! Thanks, Joshua Colp -- _ -- Bandwidth

[asterisk-dev] Media Format Work

2014-01-21 Thread Joshua Colp
to respond to this email or join us on the #asterisk-dev IRC channel. Have a spectacular day! [1] https://wiki.asterisk.org/wiki/display/AST/Media+Format+Rewrite [2] http://svn.asterisk.org/svn/asterisk/team/group/media_formats/ Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-21 Thread Joshua Colp
://reviewboard.asterisk.org/r/3102 with a comment that it breaks NAT, as it should then check against localnets to see if it should or shouldn't mangle the address, that would be cool. - Joshua Colp On Jan. 6, 2014, 8:06 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-21 Thread Joshua Colp
that the correct IP address for each interface went into the message. Some additional testing by others would be nice. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3149: manager: ExtensionStatus event status human readable

2014-01-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3149/#review10674 --- Ship it! Ship It! - Joshua Colp On Jan. 22, 2014, 7:04 p.m

Re: [asterisk-dev] [Code Review] 3143: pjsip_configuration: in ast_sip_auth_array_init, change assert(auths-names == NULL) to ast_sip_auth_array_destroy(auths)

2014-01-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3143/#review10675 --- Ship it! Ship It! - Joshua Colp On Jan. 20, 2014, 10:03

Re: [asterisk-dev] [Code Review] 3139: chan_pjsip: Test that all configured codecs are present in INVITE when sending

2014-01-25 Thread Joshua Colp
PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3139/diff/ Testing --- Ran test. Without patch that fixes issue it failed, with patch it passes. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3140: chan_pjsip: Send configured codecs even when core requests a specific one

2014-01-25 Thread Joshua Colp
now. Ran test and confirmed it passes with change. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] DTLS-SRTP SDP correction?

2014-01-28 Thread Joshua Colp
5939 (SDP capability negotiation) which changes things. Asterisk doesn't support this. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] DTLS-SRTP SDP correction?

2014-01-28 Thread Joshua Colp
... -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

2014-01-28 Thread Joshua Colp
--- On Jan. 21, 2014, 12:48 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3145

Re: [asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

2014-01-28 Thread Joshua Colp
/asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3145/diff/ Testing --- Ran test, fails using branches. Applied patch for events and it passes! Thanks, Joshua Colp

Re: [asterisk-dev] DTLS setting impacts encryption setting

2014-01-28 Thread Joshua Colp
taking things into account correctly. Personally I am against optional encryption. Best effort encryption just does not make sense to me. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com

Re: [asterisk-dev] [Code Review] 3164: res_pjsip_mwi: Subscribe fails when missing aor name

2014-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3164/#review10716 --- Ship it! Ship It! - Joshua Colp On Jan. 28, 2014, 6:34 p.m

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
://reviewboard.asterisk.org/r/3168/#comment20216 You can't do this. Well, I mean, you can, it just won't persist. The contact here is from the rdata pool and will end up getting reset later or just get deallocated. You need to clone it using pjsip_hdr_clone from the dialog pool. - Joshua Colp On Jan. 30, 2014

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
://reviewboard.asterisk.org/r/3168/#comment20217 You can also use pjsip_rdata_get_dlg here to retrieve a dialog, if one is present, and have this work for non-INVITE stuff as well (just in case). - Joshua Colp On Jan. 30, 2014, 7:59 p.m., opticron wrote

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
://reviewboard.asterisk.org/r/3168/#comment20219 I would actually go so far as to do a URI comparison here... cause if this happens multiple times you are going to keep growing the dialog pool usage. - Joshua Colp On Jan. 30, 2014, 8:27 p.m., opticron wrote

Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations

2014-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/#review10730 --- Ship it! Ship It! - Joshua Colp On Jan. 30, 2014, 9:38 p.m

Re: [asterisk-dev] [Code Review] 3120: res_ari: Provide transfer messages and enable transfers

2014-02-01 Thread Joshua Colp
at messages, profited. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers

2014-02-01 Thread Joshua Colp
/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3145/diff/ Testing --- Ran test, fails using branches. Applied patch for events and it passes! Thanks, Joshua

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-02-04 Thread Joshua Colp
/ Testing --- Subscribed to an extension from a device that uses dialog-info+xml. Confirmed NOTIFY messages going out contain the expected content. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

[asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-04 Thread Joshua Colp
/ Testing --- Ran the timing test using the various timing implementations on Linux and confirmed they still work. I also placed some calls to a Playback and confirmed it works. Thanks, Joshua Colp -- _ -- Bandwidth

[asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-04 Thread Joshua Colp
unit tests, all passed. Note: I know AO2 throws a fit and it's because a container isn't getting initialized. Getting said container initialized requires beginning the hacking apart process. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3175/#review10747 --- On Feb. 4, 2014, 3:16 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread Joshua Colp
What happens if no name is specified? Should it return NULL or maybe place a uuid in there instead? - Joshua Colp On Feb. 5, 2014, 5:08 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-05 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/3175/diff/ Testing --- Ran the timing test using the various timing implementations on Linux and confirmed they still work. I also placed some calls to a Playback and confirmed it works. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3183: ARI: pass channel variables into originate as opposed to assigning after originate

2014-02-06 Thread Joshua Colp
://reviewboard.asterisk.org/r/3183/#comment20313 Should this actually just completely fail this? Otherwise you get a list which doesn't contain all of your JSON variables. Which, if you experienced it would cause you to scratch your head and spend time wondering what is going on. - Joshua Colp On Feb. 5

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread Joshua Colp
called now. The ao2 container has a reference to the sorcery instance itself. You could do something where in ast_sorcery_unref if it is the last reference it is unlinked from the instances container. - Joshua Colp On Feb. 5, 2014, 8:48 p.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3180: Documenation: Configuration section naming in pjsip.conf.sample needs a little clarification

2014-02-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3180/#review10776 --- Ship it! Ship It! - Joshua Colp On Feb. 5, 2014, 9:10 p.m

Re: [asterisk-dev] [Code Review] 3183: ARI: pass channel variables into originate as opposed to assigning after originate

2014-02-06 Thread Joshua Colp
. /branches/12/res/ari/resource_channels.c https://reviewboard.asterisk.org/r/3183/#comment20321 I'd throw out an error here if we got no variables. - Joshua Colp On Feb. 6, 2014, 2:51 p.m., Matt Jordan wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 3186: AMI Security Events: document the events; add optional IEs to the events

2014-02-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3186/#review10785 --- Ship it! Ship It! - Joshua Colp On Feb. 5, 2014, 10:51 p.m

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-02-06 Thread Joshua Colp
the information to still exist for cases where you do want to get it. - Joshua Colp On Feb. 3, 2014, 8:18 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread Joshua Colp
Mark this as being safe so if someone looks at it they don't go say what - Joshua Colp On Feb. 6, 2014, 5 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same - OPTION 1

2014-02-06 Thread Joshua Colp
On Feb. 6, 2014, 3:52 p.m., Joshua Colp wrote: While this works I'm not happy with pushing this down to such a low level. What if in the future I want to filter something else? What I'd really like to see is something on top which allows you to arbitrarily filter anything

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same - OPTION 1

2014-02-06 Thread Joshua Colp
On Feb. 6, 2014, 3:52 p.m., Joshua Colp wrote: While this works I'm not happy with pushing this down to such a low level. What if in the future I want to filter something else? What I'd really like to see is something on top which allows you to arbitrarily filter anything

Re: [asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same - OPTION 2

2014-02-06 Thread Joshua Colp
and get a warning, but I still dislike the idea of hidden fields. ^_^ - Joshua Colp On Feb. 6, 2014, 6:50 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread Joshua Colp
://reviewboard.asterisk.org/r/3184/#comment20352 Er, do you mean you are unreffing an object that is already destroyed? If so setting the variables to NULL will prevent that. Once this clarification is provided this'll be good! - Joshua Colp On Feb. 6, 2014, 7:55 p.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
://reviewboard.asterisk.org/r/3178/#review10770 --- On Feb. 7, 2014, 2:59 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
apart process. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
, 2014, 2:59 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/ --- (Updated Feb. 7, 2014, 2:59 p.m

Re: [asterisk-dev] [Code Review] 3175: timing: Improve performance for most timing implementations

2014-02-07 Thread Joshua Colp
/trunk/include/asterisk/timing.h 407425 Diff: https://reviewboard.asterisk.org/r/3175/diff/ Testing --- Ran the timing test using the various timing implementations on Linux and confirmed they still work. I also placed some calls to a Playback and confirmed it works. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3199: scheduler: Remove hashtab usage.

2014-02-07 Thread Joshua Colp
the hashtab usage and uses the heap for finding things. Diffs - /trunk/main/sched.c 405157 Diff: https://reviewboard.asterisk.org/r/3199/diff/ Testing --- Ran scheduler unit test and also forced the scheduler to get used for Playback. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-07 Thread Joshua Colp
--- On Feb. 7, 2014, 2:59 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3178/ --- (Updated Feb. 7

Re: [asterisk-dev] [Code Review] 3199: scheduler: Remove hashtab usage.

2014-02-08 Thread Joshua Colp
and also forced the scheduler to get used for Playback. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3199: scheduler: Remove hashtab usage.

2014-02-11 Thread Joshua Colp
forced the scheduler to get used for Playback. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] Lightweight keepalive for websockets?

2014-02-11 Thread Joshua Colp
a const value. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] AMI and Sorcery

2014-02-13 Thread Joshua Colp
string where contacts and matches are specified on multiple lines? Hilarity, that's why. Okay, not really. No immediate answer springs to mind. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com

Re: [asterisk-dev] [Code Review] 3212: Makefile: fix so make main works without compiling deps (unless needed)

2014-02-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3212/#review10866 --- Ship it! Ship It! - Joshua Colp On Feb. 12, 2014, 8:34 a.m

[asterisk-dev] [Code Review] 3234: media_formats: Initial channel driver conversion and application conversion

2014-02-16 Thread Joshua Colp
/app_alarmreceiver.c 408257 /team/file/media_formats-impl/apps/app_agent_pool.c 408257 Diff: https://reviewboard.asterisk.org/r/3234/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3244: res_pjsip_sdp_rtp: Apply packetization rules on inbound SDP handling

2014-02-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3244/#review10921 --- Ship it! Ship It! - Joshua Colp On Feb. 20, 2014, 10:29

[asterisk-dev] [Code Review] 3251: res_bucket_sounds: Add 'sounds' URI scheme implementation

2014-02-23 Thread Joshua Colp
of metadata. Diffs - /trunk/res/res_bucket_sounds.c PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3251/diff/ Testing --- Executed CLI commands, output is as expected. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3207: HEP: Add a Homer Encapsulation Protocol (HEP) v3 capture agent module and a packet logger for PJSIP

2014-02-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3207/#review10928 --- Ship it! Ship It! - Joshua Colp On Feb. 23, 2014, 5:48 a.m

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-02-23 Thread Joshua Colp
address for each interface went into the message. Some additional testing by others would be nice. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

2014-02-24 Thread Joshua Colp
negotiation? - Joshua Colp On Feb. 24, 2014, 6:36 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3256

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-02-25 Thread Joshua Colp
getting initialized. Getting said container initialized requires beginning the hacking apart process. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3234: media_formats: Initial channel driver conversion and application conversion

2014-02-25 Thread Joshua Colp
/app_amd.c 407953 /team/file/media_formats-impl/apps/app_alarmreceiver.c 407953 /team/file/media_formats-impl/apps/app_agent_pool.c 407953 Diff: https://reviewboard.asterisk.org/r/3234/diff/ Testing --- Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3265: media_formats: Move app_fax over

2014-02-25 Thread Joshua Colp
Description --- This change moves app_fax over to the new media formats API. Diffs - /team/file/media_formats-impl/apps/app_fax.c 408263 Diff: https://reviewboard.asterisk.org/r/3265/diff/ Testing --- It compiles. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3266: media_formats: Move codecs over.

2014-02-25 Thread Joshua Colp
-impl/codecs/codec_adpcm.c 407954 /team/file/media_formats-impl/codecs/codec_a_mu.c 407953 Diff: https://reviewboard.asterisk.org/r/3266/diff/ Testing --- They compile, yay! Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

2014-02-25 Thread Joshua Colp
On Feb. 24, 2014, 10:51 p.m., Joshua Colp wrote: /branches/11/res/res_rtp_asterisk.c, lines 554-560 https://reviewboard.asterisk.org/r/3256/diff/1/?file=54416#file54416line554 Agreed, and pjnath does not provide a mechanism to do just that without destroying/re-creating as Matt

Re: [asterisk-dev] [Code Review] 3245: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

2014-02-25 Thread Joshua Colp
/res_pjsip_send_to_voicemail.c https://reviewboard.asterisk.org/r/3245/#comment20572 Pfft, using RAII_VAR here is silly. - Joshua Colp On Feb. 20, 2014, 11:01 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

2014-02-25 Thread Joshua Colp
On Feb. 24, 2014, 10:51 p.m., Joshua Colp wrote: /branches/11/res/res_rtp_asterisk.c, lines 554-560 https://reviewboard.asterisk.org/r/3256/diff/1/?file=54416#file54416line554 Agreed, and pjnath does not provide a mechanism to do just that without destroying/re-creating as Matt

Re: [asterisk-dev] [Code Review] 3245: res_pjsip_send_to_voicemail: transferring to voicemail for digium phones

2014-02-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3245/#review10952 --- Ship it! Ship It! - Joshua Colp On Feb. 25, 2014, 5:20 p.m

Re: [asterisk-dev] [Code Review] 3267: pjsip: avoid edge case potential crash in answer()

2014-02-26 Thread Joshua Colp
is removed from the INVITE session. Any attempts to answer the INVITE session after this results in a crash as it requires the INVITE transaction to exist. This change explicitly locks the dialog and checks to ensure that the INVITE transaction exists before answering. - Joshua

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

2014-02-26 Thread Joshua Colp
On Feb. 24, 2014, 10:51 p.m., Joshua Colp wrote: /branches/11/res/res_rtp_asterisk.c, lines 554-560 https://reviewboard.asterisk.org/r/3256/diff/1/?file=54416#file54416line554 Agreed, and pjnath does not provide a mechanism to do just that without destroying/re-creating as Matt

Re: [asterisk-dev] [Code Review] 3240: res_pjsip_exten_state: Presence for digium phones

2014-02-26 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3240/#review10961 --- Ship it! Ship It! - Joshua Colp On Feb. 21, 2014, 5 p.m

Re: [asterisk-dev] [Code Review] 3267: pjsip: avoid edge case potential crash in answer()

2014-02-26 Thread Joshua Colp
://reviewboard.asterisk.org/r/3267/#comment20588 Throw the channel name and endpoint in here for easier debugging further down the road. - Joshua Colp On Feb. 26, 2014, 6:41 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 3267: pjsip: avoid edge case potential crash in answer()

2014-02-26 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3267/#review10963 --- Ship it! Ship It! - Joshua Colp On Feb. 26, 2014, 6:52 p.m

Re: [asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

2014-02-27 Thread Joshua Colp
and try to find other cases. - Joshua Colp On Feb. 27, 2014, 3:01 p.m., Michael Young wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3272

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

2014-02-27 Thread Joshua Colp
://reviewboard.asterisk.org/r/3256/#comment20611 There's actually a bug here you didn't cause, but can fix! If the component is RTP then rtp-s should be used, if the component is RTCP then rtp-rtcp-s should be used. Otherwise looks good! - Joshua Colp On Feb. 27, 2014, 4:38 p.m., Jonathan

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

2014-02-27 Thread Joshua Colp
On Feb. 27, 2014, 6:14 p.m., Joshua Colp wrote: /branches/11/res/res_rtp_asterisk.c, line 1689 https://reviewboard.asterisk.org/r/3256/diff/2/?file=54884#file54884line1689 There's actually a bug here you didn't cause, but can fix! If the component is RTP then rtp-s

Re: [asterisk-dev] [Code Review] 3256: res_rtp_asterisk: Undo regression from ASTERISK-23213 while working around PJNATH assertion abort from ASTERISK-22911

2014-02-27 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3256/#review10980 --- Ship it! Ship It! - Joshua Colp On Feb. 27, 2014, 6:41 p.m

Re: [asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

2014-02-27 Thread Joshua Colp
remote candidates into proposed and then moving them to active? - Joshua Colp On Feb. 27, 2014, 8:02 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3275

Re: [asterisk-dev] [Code Review] 3272: func_audiohookinheritance: Check If Channel Was Specified

2014-02-27 Thread Joshua Colp
On Feb. 27, 2014, 4:26 p.m., Joshua Colp wrote: This is fine but we should probably do an audit and try to find other cases. Corey Farrell wrote: If nobody is working on the audit of channel usage in dialplan functions I can. Should I start a new JIRA ticket? That'd be nifty

Re: [asterisk-dev] PJSIP transport problem

2014-02-28 Thread Joshua Colp
of Apache on port 80. Instead of binding both to 0.0.0.0 you can bind them to two different interface IP addresses if you want. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] PJSIP debug question

2014-02-28 Thread Joshua Colp
commands: pjsip set logger on pjsip set logger on host/IP address pjsip set logger off You can also enable it at startup by using the debug option in the global section of res_pjsip.conf -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check

Re: [asterisk-dev] PJSIP transport problem

2014-02-28 Thread Joshua Colp
is behind NAT. They specify what is local to it so SIP messages don't get rewritten, or if going outside of that - they do get rewritten to the external address. The options used when a remote endpoint is behind NAT are: force_rport=yes rtp_symmetric=yes rewrite_contact=yes -- Joshua Colp Digium

Re: [asterisk-dev] PJSIP transport problem

2014-02-28 Thread Joshua Colp
)? It's kind of a bummer to have phones that think they are still registered, but you can't reach them. Looked thru the literature, haven't seen anything juicy about this. OPTIONS functionality is controlled by specifying qualify_frequency on the AOR. -- Joshua Colp Digium, Inc. | Senior Software

Re: [asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

2014-03-03 Thread Joshua Colp
://reviewboard.asterisk.org/r/3275/#comment20658 This will crash and left_candidate will never be non-NULL. Take out that ao2_ref and this is good to go. - Joshua Colp On March 3, 2014, 5:01 p.m., Jonathan Rose wrote

Re: [asterisk-dev] PJSIP and persistent TLS

2014-03-03 Thread Joshua Colp
, which of course fails. Any ideas? What's the exact configuration in use? Do you have a transport explicitly specified for the endpoint? Doing so will currently cause it to try to create a new connection [1]. [1] https://issues.asterisk.org/jira/browse/ASTERISK-22658 Cheers, -- Joshua Colp

Re: [asterisk-dev] [Code Review] 3275: res_rtp_asterisk: Fix the one way audio problems when resuming held calls with ICE

2014-03-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3275/#review11028 --- Ship it! Ship It! - Joshua Colp On March 3, 2014, 6:02 p.m

Re: [asterisk-dev] PJSIP and persistent TLS

2014-03-03 Thread Joshua Colp
connection. What happens if you use rewrite_contact=yes on the endpoint? Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-03-04 Thread Joshua Colp
://reviewboard.asterisk.org/r/3102/#review11060 --- On Feb. 23, 2014, 5:57 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https

[asterisk-dev] [Code Review] 3299: res_stasis_recording: Add target URI to recording events.

2014-03-05 Thread Joshua Colp
://reviewboard.asterisk.org/r/3299/diff/ Testing --- Started recordings and confirmed target_uri is as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

[asterisk-dev] [Code Review] 3303: Add test for nominal recording usage in ARI.

2014-03-05 Thread Joshua Colp
/recording/nominal/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3303/diff/ Testing --- Ran test, it passes. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread Joshua Colp
On March 6, 2014, 1:38 a.m., Matt Jordan wrote: branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 364-371 https://reviewboard.asterisk.org/r/3283/diff/1/?file=55030#file55030line364 Any reason you decided to move initialization of the members of the struct to load_module?

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread Joshua Colp
with other stuff, it may not be. Can't know. The set_extended usage has to go. Create a structure to contain additional information, put stuff in that, and pass it in. - Joshua Colp On March 3, 2014, 12:26 a.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3305: Sorcery: Be lenient when extra realtime fields are retrieved.

2014-03-06 Thread Joshua Colp
/r/3305/#comment20740 Less RAII_VAR please. :P - Joshua Colp On March 5, 2014, 11:40 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3305

Re: [asterisk-dev] [Code Review] 3304: pjsip configuration: Make TOS values for transports consistent in behavior to TOS values in endpoints. Allow DSCP strings to be used for TOS configuration. Fix A

2014-03-06 Thread Joshua Colp
://reviewboard.asterisk.org/r/3304/#comment20741 Remove. - Joshua Colp On March 5, 2014, 8:19 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3304

Re: [asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same (take 8)

2014-03-06 Thread Joshua Colp
while here. - Joshua Colp On March 4, 2014, 10:56 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3193

Re: [asterisk-dev] [Code Review] 3193: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same (take 8)

2014-03-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3193/#review11097 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 3:44 p.m

Re: [asterisk-dev] [Code Review] 3299: res_stasis_recording: Add target URI to recording events.

2014-03-06 Thread Joshua Colp
409828 /branches/12/include/asterisk/stasis_app_recording.h 409828 Diff: https://reviewboard.asterisk.org/r/3299/diff/ Testing --- Started recordings and confirmed target_uri is as expected. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3303: Add test for nominal recording usage in ARI.

2014-03-06 Thread Joshua Colp
/tests/rest_api/recording/nominal/recording.py PRE-CREATION /asterisk/trunk/tests/rest_api/recording/nominal/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3303/diff/ Testing --- Ran test, it passes. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-03-07 Thread Joshua Colp
throws a fit and it's because a container isn't getting initialized. Getting said container initialized requires beginning the hacking apart process. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/#review11132 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 9:51 p.m

Re: [asterisk-dev] [Code Review] 3234: media_formats: Initial channel driver conversion and application conversion

2014-03-07 Thread Joshua Colp
407953 /team/file/media_formats-impl/apps/app_amd.c 407953 /team/file/media_formats-impl/apps/app_alarmreceiver.c 407953 /team/file/media_formats-impl/apps/app_agent_pool.c 407953 Diff: https://reviewboard.asterisk.org/r/3234/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3266: media_formats: Move codecs over.

2014-03-07 Thread Joshua Colp
/codec_dahdi.c 407953 /team/file/media_formats-impl/codecs/codec_alaw.c 407953 /team/file/media_formats-impl/codecs/codec_adpcm.c 407954 /team/file/media_formats-impl/codecs/codec_a_mu.c 407953 Diff: https://reviewboard.asterisk.org/r/3266/diff/ Testing --- They compile, yay! Thanks, Joshua

Re: [asterisk-dev] [Code Review] 3265: media_formats: Move app_fax over

2014-03-07 Thread Joshua Colp
--- It compiles. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

<    1   2   3   4   5   6   7   8   9   10   >