Re: [PATCH] ath: change logging functions to return void

2014-09-22 Thread Kalle Valo
Joe Perches writes: > The return values are not used by callers of these functions > so change the functions to return void. > > Other miscellanea: > > o add __printf verification to wil6210 logging functions > No format/argument mismatches found > > Signed-off-by: Joe Perches > --- > This cha

Rate ctrl problem with 2x2 station.

2014-09-22 Thread Ben Greear
While testing the previously posted patches that fix up the transmit rate for 3x3 NICs configured for 2x2 chainmask, I noticed that an ath10k configured as 3x3 AP will use only 1x1 rates when transmitting to a 2x2 station. >From debugging so far, it appears the root cause is that the method ath10k

[PATCH] ath10k: use configured nss instead of max nss.

2014-09-22 Thread greearb
From: Ben Greear When re-associating a station, the nss was set back to maximum value even if user had configured small number of tx chains. So, pay attention to user's config in this case as well. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 11 +-- 1 file ch

[PATCH 2/2] ath10k: apply chainmask settings to vdev on creation.

2014-09-22 Thread greearb
From: Ben Greear It appears it takes more than just setting the hardware's chainmask to make things work well. Without this patch, a vdev would only use 1x1 rates when chainmask was set to 0x3. Setting the 'nss' (number of spatial streams) on the vdev helps the firmware's rate-control algorithm

[PATCH 1/2] ath10k: make firmware text debug messages more verbose.

2014-09-22 Thread greearb
From: Ben Greear There are not many of these messages producted by the firmware, but they are generally fairly useful, so print them at info level. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

Re: Dusseldorf: LPC special session on ath10k

2014-09-22 Thread Dave Taht
On Mon, Sep 22, 2014 at 12:26 PM, Kathy Giori wrote: > Hey there ath10k enthusiasts, > > The afternoon prior to the Linux wireless summit that John Linville > and Johannes Berg are hosting: > http://www.linuxplumbersconf.org/2014/ocw/events/LPC2014/tracks/339 > > we've reserved a conference room t

Dusseldorf: LPC special session on ath10k

2014-09-22 Thread Kathy Giori
Hey there ath10k enthusiasts, The afternoon prior to the Linux wireless summit that John Linville and Johannes Berg are hosting: http://www.linuxplumbersconf.org/2014/ocw/events/LPC2014/tracks/339 we've reserved a conference room to focus on ath10k topics of interest. If you have specific items y

Using host's rate-ctrl in ath10k?

2014-09-22 Thread Ben Greear
Has anyone looked into what it would take to use standard host OS's rate control (minstrel_ht) with ath10k? I suspect the ath10k rate control logic in the firmware is a bit dodgy, and it would be nice to use something with wider testing such as minstrel_ht... Thanks, Ben -- Ben Greear Candela

[PATCH] ath: change logging functions to return void

2014-09-22 Thread Joe Perches
The return values are not used by callers of these functions so change the functions to return void. Other miscellanea: o add __printf verification to wil6210 logging functions No format/argument mismatches found Signed-off-by: Joe Perches --- This change is associated to a desire to eventual

Re: [PATCH 2/3] ath10k: dump hex bytes with dev string prefix

2014-09-22 Thread Kalle Valo
Michal Kazior writes: > On 22 September 2014 12:52, Kalle Valo wrote: >> Michal Kazior writes: >> >>> - print_hex_dump_bytes(prefix, DUMP_PREFIX_OFFSET, buf, len); >>> + for (ptr = buf; (ptr - buf) < len; ptr += 16) { >>> + linebuflen = 0; >>> +

Re: [PATCH 2/3] ath10k: dump hex bytes with dev string prefix

2014-09-22 Thread Michal Kazior
On 22 September 2014 12:52, Kalle Valo wrote: > Michal Kazior writes: > >> This makes it easier to debug hex dumps on systems >> with more than a single ath10k device. >> >> Signed-off-by: Michal Kazior > > [...] > >> - print_hex_dump_bytes(prefix, DUMP_PREFIX_OFFSET, buf, len); >> +

Re: [PATCH 2/3] ath10k: dump hex bytes with dev string prefix

2014-09-22 Thread Kalle Valo
Michal Kazior writes: > This makes it easier to debug hex dumps on systems > with more than a single ath10k device. > > Signed-off-by: Michal Kazior [...] > - print_hex_dump_bytes(prefix, DUMP_PREFIX_OFFSET, buf, len); > + for (ptr = buf; (ptr - buf) < len; ptr += 16) {

Re: [PATCH 6/9] ath10k: deduplicate wmi service ready logic

2014-09-22 Thread Michal Kazior
On 22 September 2014 11:46, Kalle Valo wrote: > Michal Kazior writes: [...] > Like discussed in IRC, you don't need to resent the whole patchset just > because of this. I have now folded the patch below onto your patch in > ath-next-test, please review: > > https://github.com/kvalo/ath/commit/1d1

Re: [PATCH 1/3] ath10k: print wmi version info

2014-09-22 Thread Kalle Valo
Michal Kazior writes: > HTT version is already printed so print WMI > version as well for consistency. > > Signed-off-by: Michal Kazior > --- > drivers/net/wireless/ath/ath10k/debug.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10

Re: [PATCH 6/9] ath10k: deduplicate wmi service ready logic

2014-09-22 Thread Kalle Valo
Michal Kazior writes: > On 19 September 2014 10:37, Kalle Valo wrote: >> Michal Kazior writes: >> >>> + if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) { >>> + ret = ath10k_wmi_10x_pull_svc_rdy_ev(skb, &arg); >>> + wmi_10x_svc_map(arg.service_map, svc_bmap)