[PATCH v1 1/3] ath10k: Enable debugfs provision to enable Peer Stats feature

From: Mohammed Shafi Shajakhan Provide a debugfs entry to enable/ disable Peer Stats feature. Peer Stats feature is for developers/users who are more interested in studying in Rx/Tx stats with multiple clients connected, hence disable this by default. Enabling this

Re: [RFCv2 0/3] mac80211: implement fq codel

TxOP 0 has a special meaning in the standard. For HT/VHT it means the it is actually limited to 5484us (mixed-mode) or 1us (greenfield). I suspect the BK/BE latency difference has to do with the fact that there's bulk traffic going on BE queues (this isn't reflected explicitly in the plots).

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

Hi Mohammed, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20160317] [cannot apply to v4.5] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

[ath6kl:master 1455/1465] drivers/net/ethernet/mellanox/mlx5/core/en.h:289:6: error: duplicate member 'nop'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git master head: 1d83ef1c3bcc2d8c955ca0a1870d2c4386df7e59 commit: a0e616b3696dfccf6a769e666da6cc283ef2afd9 [1455/1465] Merge remote-tracking branch 'wireless-drivers-next/master' config: arm-allmodconfig (attached as .config)

Re: [PATCH 2/2] ath10k: Enable parsing per station rx duration for 10.4

On Wed, Mar 16, 2016 at 10:22:22AM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan writes: > > > From: Mohammed Shafi Shajakhan > > > > Rx duration support for per station is part of extended peer > > stats, enable provision to parse

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

On 17 March 2016 at 12:20, Mohammed Shafi Shajakhan wrote: > Hi Michal, > > On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote: >> On 17 March 2016 at 11:48, Mohammed Shafi Shajakhan >> wrote: >> [...] >> > +void

[PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4

From: Mohammed Shafi Shajakhan Rx duration support for per station is part of extended peer stats, enable provision to parse the same and provide backward compatibility based on the 'stats_id' event Signed-off-by: Mohammed Shafi Shajakhan

Re: [RFCv2 0/3] mac80211: implement fq codel

I've re-tested selected cases with wmm_enabled=0 set on the DUT AP. I'm attaching results. Naming: * "old-" is without mac/ath10k changes (referred to as kvalo-reverts previously) and fq_codel on qdiscs, * "patched-" is all patches applied (both mac and ath), * "-be-bursts" is stock "bursts"

Why does the driver configure only 2 keys per peer?

For instance: #define TARGET_10_4_NUM_PEER_KEYS 2 But, there are 4 key-ids, and so the driver can attempt to allocate 3 per peer. Now, the self-peer probably only has one key ever (and that is blank key), but that still averages to 5 per vdev (when vdev has 2 peers), and if AP

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

Hi Michal, thanks for the comments .. On Thu, Mar 17, 2016 at 12:35:00PM +0100, Michal Kazior wrote: > On 17 March 2016 at 12:20, Mohammed Shafi Shajakhan > wrote: > > Hi Michal, > > > > On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote: > >> On 17 March

Re: [PATCH v2] ath10k: fix debugfs pktlog_filter write

writes: > From: Anilkumar Kolli > > It is observed that, we are disabling the packet log if we write same > value to the pktlog_filter for the second time. Always enable pktlogs > on non zero filter. > > Fixes: 90174455ae05 ("ath10k: add support

Re: Why does the driver configure only 2 keys per peer?

No, the hardware can handle plenty of slots...looks to me like no one actually tested to the configured limits and/or they got lucky while testing. As long as it is possible for user-space to (temporarily?) configure 4 keys per peer, then the firmware can assert. I'll just increase the keys per

Re: [RFCv2 0/3] mac80211: implement fq codel

On Wed, Mar 16, 2016 at 11:36:31AM -0700, Dave Taht wrote: > That is the sanest 802.11e queue behavior I have ever seen! (at both > 6 and 300mbit! in the ath10k patched mac test) Out of curiosity, why does BE have larger latency than BK in that chart? I'd have expected the opposite. -- Bob

Re: [PATCH] dt: bindings: add new dt entry for pre calibration in qcom,ath10k.txt

On Thu, Mar 10, 2016 at 03:42:04PM +0530, Raja Mani wrote: > There two things done in this patch, > > 1) Existing device tree entry 'qcom,ath10k-calibration-data' carries >not only calibration data, it carries board specific data too. >So, make appropriate update in doc. > > 2) ipq4019

Re: [RFCv2 0/3] mac80211: implement fq codel

On 16 March 2016 at 16:37, Dave Taht wrote: > it is helpful to name the test files coherently in the flent tests, in > addition to using a directory structure and timestamp. It makes doing > comparison plots in data->add-other-open-data-files simpler. "-t >

Re: [PATCH 1/2] ath10k: Introduce Extended Resource Config support for 10.4

Mohammed Shafi Shajakhan writes: > From: Raja Mani > > Add API support for Extended Resource Configuration for 10.4. This > is useful to enable new features like Peer Stats, LTEU etc if the > firmware advertises support for the service. This is

Re: [PATCH] ath10k: free cached fw bin contents when get board id fails

Raja Mani writes: > ath10k_core_probe_fw() simply returns error without freeing > cached firmware file content when get board id operation fails. > Free cached fw bin data in failure case to avoid memory leak. > > Fixes: db0984e51a18 ("ath10k: select board data based on

Re: [PATCH] ath10k: Advertise force AP scan feature

Vasanthakumar Thiagarajan writes: > Results obtained from scan can be used for spectrum management by > doing something like building information of preferred channel > lists and sharing them with stations around. It is to be noted > that traffic to the connected

[PATCH 0/2] ath10k: fix tx hangs

Hi, My recent wake-tx-queue/pull-push related patches introduced a regression that can cause tx to hang under certain circumstances. Michal Kazior (2): ath10k: fix tx hang ath10k: fix pull-push tx threshold handling drivers/net/wireless/ath/ath10k/mac.c | 22 +++--- 1 file

Re: [RFCv2 0/3] mac80211: implement fq codel

On Thu, Mar 17, 2016 at 09:55:03AM +0100, Michal Kazior wrote: > If you consider Wi-Fi is half-duplex and latency in the entire stack > (for processing ICMP and UDP_RR) is greater than 11e contention window > timings you can get your BE flow responses with extra delay (since > other queues might

Re: [Codel] [RFCv2 0/3] mac80211: implement fq codel

On 03/17/2016 10:00 AM, Dave Taht wrote: netperf's udp_rr is not how much traffic conventionally behaves. It doesn't do tcp slow start or congestion control in particular... Nor would one expect it to need to, unless one were using "burst mode" to have more than one transaction inflight at

Re: [PATCH v5] ath10k: Enable debugfs provision to enable Peer Stats feature

Hi Kalle, I had resent this change (to avoid any confusions with compilation issues) as a part of the below series [PATCH v1 1/3] ath10k: Enable debugfs provision to enable Peer Stats feature [PATCH v1 2/3] ath10k: Introduce Extended Resource Config support for 10.4 [PATCH v1 3/3] ath10k: Enable

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

Hi Michal, On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote: > On 17 March 2016 at 11:48, Mohammed Shafi Shajakhan > wrote: > [...] > > +void ath10k_sta_statistics(struct ieee80211_hw *hw, struct ieee80211_vif > > *vif, > > +

[PATCH 2/2] ath10k: fix pull-push tx threshold handling

This prevents tx hangs or hiccups if pull-push supporting firmware defines per-txq thresholds or switches modes dynamically. Fixes: 299468782d94 ("ath10k: implement wake_tx_queue") Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 14

Re: [RFCv2 0/3] mac80211: implement fq codel

it is helpful to name the test files coherently in the flent tests, in addition to using a directory structure and timestamp. It makes doing comparison plots in data->add-other-open-data-files simpler. "-t patched-mac-300mbps", for example. Also netperf from svn (maybe 2.7, don't remember) will