Re: [PATCH v2 1/5] ath10k: fix checkpatch warnings related to spaces

2016-04-14 Thread Joe Perches
On Wed, 2016-04-13 at 14:13 +0300, Kalle Valo wrote: > Fix checkpatch warnings about use of spaces with operators: > spaces preferred around that '*' (ctx:VxV) > This has been recently added to checkpatch. Trivia: That's not a particularly recent change. > diff --git a/drivers/net/wireless/ath/at

Re: [PATCH 1/8] ath10k: remove deprecated firmware API 1 support

2016-04-14 Thread Valo, Kalle
Kalle Valo writes: > This has ben deprecated years ago, I haven't heard anyone using it since and > most likely it won't even work anymore. So just remove all of it. > > Signed-off-by: Kalle Valo [...] > --- a/drivers/net/wireless/ath/ath10k/hw.h > +++ b/drivers/net/wireless/ath/ath10k/hw.h >

Re: QCA998X not working at all

2016-04-14 Thread Sebastian Gottschall
Am 13.04.2016 um 17:36 schrieb Ben Greear: On 11/19/2015 10:21 AM, Sebastian Gottschall wrote: simple solution. as for ath9k. otp must be ignored for various chipsets, since they wont return valid results --- core.c (Revision 2702) +++ core.c (Arbeitskopie) @@ -1735,9 +1735,8 @@ ret = at

Re: QCA998X not working at all

2016-04-14 Thread Sebastian Gottschall
Am 13.04.2016 um 19:05 schrieb Alexis Green: How about only ignoring the error only if there's caldata. Could be a good middle ground. This is a patch I submitted to OpenWRT a while ago as part of Netgear X4 support - https://patchwork.ozlabs.org/patch/601352/ even then its not clear if this fun

Re: [patch v2] ath10k: add some sanity checks

2016-04-14 Thread Valo, Kalle
Dan Carpenter writes: > Smatch complains that since "ev->peer_id" comes from skb->data that > means we can't trust it and have to do a bounds check on it to prevent > an array overflow. > > Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup') > Signed-off-by: Dan Carpenter In ath.git pendin