Re: [PATCH v6 06/10] ath10k: add sdio extra initializations

2017-03-15 Thread Ryan Hsu
On 03/15/2017 08:46 AM, Kalle Valo wrote: > From: Erik Stromdahl > > Extra initializations needed by all sdio boards. > Derived from qcacld. > > Signed-off-by: Erik Stromdahl > Signed-off-by: Kalle Valo > --- > drivers/net/wireless/ath/ath10k/core.c | 22 -- > 1 file chan

Re: [PATCH v6 03/10] ath10k: htc: move htc ctrl ep connect to htc_init

2017-03-15 Thread Ryan Hsu
On 03/15/2017 08:45 AM, Kalle Valo wrote: > From: Erik Stromdahl > > This patch moves the HTC ctrl service connect from > htc_wait_target to htc_init. > > This is done in order to make sure the htc ctrl service > is setup properly before hif_start is called. > > The reason for this is that we wan

Re: [RFC v4 06/21] ath10k: sdio support

2017-03-15 Thread Erik Stromdahl
On 2017-03-15 13:09, Kalle Valo wrote: Erik Stromdahl writes: On 2017-03-10 13:43, Valo, Kalle wrote: "Valo, Kalle" writes: Erik Stromdahl writes: sdio/mailbox HIF implementation. Signed-off-by: Erik Stromdahl I'm looking at this more carefully now and noticed this: +static int

[PATCH] ath10k: remove redundant check of len with buf_len

2017-03-15 Thread Colin King
From: Colin Ian King The check of len > buf_len is redundant as len is initialized to 0 and buf_len to 4096, so this comparison is always false. Remove it. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/debug.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/ne

Re: Should ath10k enable RX_FLAG_ALLOW_SAME_PN

2017-03-15 Thread Adrian Chadd
have you verified with a sniffer that it indeed is an A-MSDU that the hardware is decap'ing for you? (ath9k doesn't do hardware A-MSDU decap.) -adrian On 15 March 2017 at 08:26, Ben Greear wrote: > We notice a strange problem when receiving ath10k frames in > raw mode (with modified firmware).

[PATCH v6 10/10] ath10k: sdio support

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl sdio/mailbox HIF implementation. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/Kconfig |6 drivers/net/wireless/ath/ath10k/Makefile |3 drivers/net/wireless/ath/ath10k/sdio.c | 2102 ++

[PATCH v6 09/10] ath10k: different fw file names for usb and sdio

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Since both SDIO and USB based chipsets will use different firmware from the PCIe and AHB chipsets, the fw file name must be different depending on bus type. The new firmware names are: For PCIe and AHB: firmware-.bin (same as before) For SDIO: firmware-sdio-.bin Signed-of

[PATCH v6 08/10] ath10k: htc: ready_ext msg support

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Added support for extended ready message. The extended ready message contains the maximum bundle count supported by SDIO chipsets. It is transmitted by SDIO chipset only and replaces the "standard" ready message in this case. Signed-off-by: Erik Stromdahl Signed-off-by: Ka

[PATCH v6 07/10] ath10k: sdio get target info

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Special BMI get target info function for SDIO. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/bmi.c | 71 drivers/net/wireless/ath/ath10k/bmi.h |2 + drivers/net/wireless/ath/ath10k/core

[PATCH v6 06/10] ath10k: add sdio extra initializations

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Extra initializations needed by all sdio boards. Derived from qcacld. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/n

[PATCH v6 05/10] ath10k: various sdio related definitions

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Debug masks for SDIO HIF layer. Address definitions for SDIO/mbox based chipsets. Augmented struct host_interest with more members. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.h |3 ++ drivers/net/wireless/ath/

[PATCH v6 04/10] ath10k: htc: refactorization

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Code refactorization: Moved the code for ep 0 in ath10k_htc_rx_completion_handler to ath10k_htc_control_rx_complete. This eases the implementation of SDIO/mbox significantly since the ep_rx_complete cb is invoked directly from the SDIO/mbox hif layer. Since the ath10k_htc_

[PATCH v6 03/10] ath10k: htc: move htc ctrl ep connect to htc_init

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl This patch moves the HTC ctrl service connect from htc_wait_target to htc_init. This is done in order to make sure the htc ctrl service is setup properly before hif_start is called. The reason for this is that we want the HTC ctrl service callback to be initialized before t

[PATCH v6 01/10] ath10k: htc: made static function public

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Changed ath10k_htc_notify_tx_completion and ath10k_htc_process_trailer from static to non static. These functions are needed by SDIO/mbox. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/htc.c | 14 -- drivers/net

[PATCH v6 02/10] ath10k: htc: rx trailer lookahead support

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl The RX trailer parsing is now capable of parsing lookahead reports. A lookahead contains the first 4 bytes of the next HTC message (that will be read in the next SDIO read operation). Lookaheads are used by the SDIO/mbox HIF layer to determine if the next message is part of a

[PATCH v6 00/10] ath10k: sdio support

2017-03-15 Thread Kalle Valo
I did some changes while reviewing Erik's SDIO patches. Only compile tested, I don't have any SDIO boards at the moment. Changes in v6: * resubmit due to stgit problems Changes in v5: * promote from RFC to PATCH * move "ath10k: sdio support" patch to last * in "ath10k: sdio get target info" f

Should ath10k enable RX_FLAG_ALLOW_SAME_PN

2017-03-15 Thread Ben Greear
We notice a strange problem when receiving ath10k frames in raw mode (with modified firmware). The very first data message (UDP discovery response) is dropped in WPA2 + AES mode, and it appears that if we would set the RX_FLAG_ALLOW_SAME_PN it would be accepted. ath9k in software-crypt mode does

Re: [PATCH v5 00/10] ath10k: sdio support

2017-03-15 Thread Kalle Valo
Kalle Valo writes: > I did some changes while reviewing Erik's SDIO patches. Only compile > tested, I don't have any SDIO boards at the moment. Only the first three patches were submitted so please ignore this patchset. I'll investigate what's wrong and resubmit v6 once it works again. -- Kall

[PATCH v5 01/10] ath10k: htc: made static function public

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl Changed ath10k_htc_notify_tx_completion and ath10k_htc_process_trailer from static to non static. These functions are needed by SDIO/mbox. Signed-off-by: Erik Stromdahl Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/htc.c | 14 -- drivers/net

[PATCH v5 03/10] ath10k: htc: move htc ctrl ep connect to htc_init

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl This patch moves the HTC ctrl service connect from htc_wait_target to htc_init. This is done in order to make sure the htc ctrl service is setup properly before hif_start is called. The reason for this is that we want the HTC ctrl service callback to be initialized before t

[PATCH v5 02/10] ath10k: htc: rx trailer lookahead support

2017-03-15 Thread Kalle Valo
From: Erik Stromdahl The RX trailer parsing is now capable of parsing lookahead reports. A lookahead contains the first 4 bytes of the next HTC message (that will be read in the next SDIO read operation). Lookaheads are used by the SDIO/mbox HIF layer to determine if the next message is part of a

[PATCH v5 00/10] ath10k: sdio support

2017-03-15 Thread Kalle Valo
I did some changes while reviewing Erik's SDIO patches. Only compile tested, I don't have any SDIO boards at the moment. Changes in v5: * promote from RFC to PATCH * move "ath10k: sdio support" patch to last * in "ath10k: sdio get target info" fix sparse warning by changing tmp variable to __

Re: [RFC v4 06/21] ath10k: sdio support

2017-03-15 Thread Kalle Valo
Erik Stromdahl writes: > On 2017-03-10 13:43, Valo, Kalle wrote: >> "Valo, Kalle" writes: >> >>> Erik Stromdahl writes: >>> sdio/mailbox HIF implementation. Signed-off-by: Erik Stromdahl >>> >>> I'm looking at this more carefully now and noticed this: >>> +static int ath10k

Re: ath10k - spectral scan - and - channel change

2017-03-15 Thread Will Kerr
not dumb at all - I started to try most things, here what happens when I tried it: root@OpenWrt:~# cd /sys/kernel/debug/ieee80211/phy0/ath10k/ root@OpenWrt:/sys/kernel/debug/ieee80211/phy0/ath10k# echo disable > spectral_scan_ctl ash: write error: No such device root@OpenWrt:/sys/kernel/debug/i

Re: ath10k - spectral scan - and - channel change

2017-03-15 Thread Will Kerr
> [shafi] hmmm interesting .. looks like you need to bring the interface up, > before doing this, the WMI command may respond error I thought it was, at least now when I try: AP mode: (its OK) Monitor Mode: root@OpenWrt:~# ifconfig wlan0 up root@OpenWrt:~# echo disable > /sys/kernel/debug/ieee8

Re: ath10k - spectral scan - and - channel change

2017-03-15 Thread Mohammed Shafi Shajakhan
On Wed, Mar 15, 2017 at 11:14:19AM +, Will Kerr wrote: > > [shafi] hmmm interesting .. looks like you need to bring the interface up, > > before doing this, the WMI command may respond error > > I thought it was, at least now when I try: > > AP mode: > (its OK) > > Monitor Mode: > root@OpenW

Re: [PATCH 2/2] ath10k: search DT for qcom, ath10k-calibration-variant

2017-03-15 Thread Sven Eckelmann
On Freitag, 10. März 2017 19:20:54 CET Christian Lamparter wrote: [...] > @Aeolus Yang / Kalle / QCA: Would it be possible to assign a variant string to > the Asus RT-AC58U? > > I've attached the necessary bmi-board-id=16 and bmi-board-id=17 board > files to this mail as well. So, all that needs