Re: [PATCH v2] ath10k: fix use-after-free in ath10k_wmi_cmd_send_nowait

2018-03-05 Thread Brian Norris
+ Felix, who had feedback on the last version On Mon, Mar 05, 2018 at 02:44:02PM +0800, Carl Huang wrote: > The skb may be freed in tx completion context before > trace_ath10k_wmi_cmd is called. This can be easily captured when > KASAN(Kernel Address Sanitizer) is enabled. The fix is to move >

Re: [PATCH 1/2] ath10k: Add WMI FWTEST command support

2018-03-05 Thread Peter Oh
From: Sathishkumar Muruganandam This patch adds support for WMI_FWTEST_CMD. This command is used for setting the wifi parameters. It's too lack of information in commit message. You should add such what values are acceptable for which purpose by each param_id and

Re: [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters

2018-03-05 Thread akolli
On 2018-03-05 13:12, Sven Eckelmann wrote: On Montag, 5. März 2018 12:29:08 CET Anilkumar Kolli wrote: @@ -496,6 +497,8 @@ struct ath10k_debug { u32 reg_addr; u32 nf_cal_period; void *cal_data; + u32 fw_test_param_id; + u32 fw_test_param_value; }; Why is