Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Sebastian Gottschall
Hello Kalle you removed the call to leds_start from certain locations but you seem to have ignored the comment i wrote above the function call. there is a reason why i reinitialize the gpio output state in these locations. the firmware for 9984 and 99xx resets the gpio registers at certain poin

Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
Kalle Valo writes: > From: Sebastian Gottschall > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based > chipsets with on chipset connected led's using WMI Firmware API. The LED > device will get available named as "ath10k-phyX" at sysfs and can be > controlled > with var

[PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
From: Sebastian Gottschall Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based chipsets with on chipset connected led's using WMI Firmware API. The LED device will get available named as "ath10k-phyX" at sysfs and can be controlled with various triggers. adds also debugfs i

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
(adding back lists) Sebastian Gottschall writes: > Am 06.04.2018 um 10:25 schrieb Kalle Valo: >> Sebastian Gottschall writes: >> >>> Am 06.04.2018 um 10:09 schrieb Kalle Valo: (adding back the lists, please don't top post and trim your quotes) Sebastian Gottschall writes: >

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
Sebastian Gottschall writes: > Am 06.04.2018 um 10:09 schrieb Kalle Valo: >> (adding back the lists, please don't top post and trim your quotes) >> >> Sebastian Gottschall writes: >> >>> okay. ath10k-check is buggy and doesnt work. so it doesnt help much >>> with code styles >>> >>> root@seg-des

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Sebastian Gottschall
Am 06.04.2018 um 10:09 schrieb Kalle Valo: (adding back the lists, please don't top post and trim your quotes) Sebastian Gottschall writes: okay. ath10k-check is buggy and doesnt work. so it doesnt help much with code styles root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check global: 'driv

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Sebastian Gottschall
Am 06.04.2018 um 10:07 schrieb Kalle Valo: Sebastian Gottschall writes: i have some comments about your check warnings. some of them are bogus. for instance they advise to use "unsigned int" instead of "unsigned". this might be better, but the original kernel header uses "unsigned" as api defi

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
(adding back the lists, please don't top post and trim your quotes) Sebastian Gottschall writes: > okay. ath10k-check is buggy and doesnt work. so it doesnt help much > with code styles > > root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check > global: 'drivers/net/wireless/ath/ath10k/Kconfig'

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
Sebastian Gottschall writes: > i have some comments about your check warnings. > some of them are bogus. for instance they advise to use "unsigned int" > instead of "unsigned". this might be better, but > the original kernel header uses "unsigned" as api definition. so i > decided to use the same

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

2018-04-06 Thread Kalle Valo
Sebastian Gottschall writes: > Am 05.04.2018 um 16:44 schrieb Kalle Valo: >> s.gottsch...@dd-wrt.com writes: >> >>> Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 >>> based chipsets with on chipset connected led's using WMI Firmware API. >>> The LED device will get available n