[PATCH v2 3/3] ath10k: Support ethtool gstats2 API.

2018-04-19 Thread greearb
From: Ben Greear Skip a firmware stats update when calling code indicates the stats refresh is not needed. Signed-off-by: Ben Greear --- v2: Convert to new flag name, attempt to fix build when there is not DEBUGFS enabled for ath10k. drivers/net/wireless/ath/ath10k/debug.c | 18 +

[PATCH v2 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread greearb
From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify flags. These flags can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow. Signed-off-by: Ben Greear --- v2: Chan

[PATCH v2 2/3] mac80211: Add support for ethtool gstats2 API.

2018-04-19 Thread greearb
From: Ben Greear This enables users to request fewer stats to be refreshed in cases where firmware does not need to be probed. Signed-off-by: Ben Greear --- v2: No changes. include/net/mac80211.h| 6 ++ net/mac80211/driver-ops.h | 9 +++-- net/mac80211/ethtool.c| 18 ++

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

2018-04-19 Thread Ben Greear
On 04/19/2018 03:10 AM, Kalle Valo wrote: Kalle Valo writes: Ben Greear writes: It seems the upstream board-2.bin file for 9984 does not yet include support for WLE1216V5-20 (or possibly it does and OpenWRT grabs the wrong one?). I'm attaching the board file for this NIC and for another on

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-19 Thread Adrian Chadd
Hi, My 2c here. As much as I like power save stuff, I've been bitten enough times by these wifi chips kinda implementing mostly-ok-but-not-that-particular-time power savings stuff and so have had to make it configurable chip by chip. A good example is active state power management in various run

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Kalle Valo
Christian Lamparter writes: > On Donnerstag, 19. April 2018 16:47:22 CEST Sven Eckelmann wrote: >> On Donnerstag, 19. April 2018 14:33:04 CEST Kalle Valo wrote: >> > >> Unfortunately, this is wrong. Please check the mail again. The >> > >> bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=OM-A62 BDF

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

2018-04-19 Thread Kalle Valo
govi...@codeaurora.org writes: > On 2018-04-18 18:46, Kalle Valo wrote: >> (fixing top posting) >> >> govi...@codeaurora.org writes: >> >>> On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Christian Lamparter
On Donnerstag, 19. April 2018 16:47:22 CEST Sven Eckelmann wrote: > On Donnerstag, 19. April 2018 14:33:04 CEST Kalle Valo wrote: > > >> Unfortunately, this is wrong. Please check the mail again. The > > >> bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=OM-A62 BDF is for the > > >> QCA9888 > > >>

Re: ath10k: Fix fw path name for WCN3990 target

2018-04-19 Thread Kalle Valo
Govind Singh wrote: > FW path is mapped incorrectly for the WCN3990 > hw version. Fix fw path with correct hw1.0 name. > > Signed-off-by: Govind Singh > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 6da2b2d46ff9 ath10k: fix fw path name for WCN3990 target --

Re: [1/2] ath10k: add inlined wrappers for htt tx ops

2018-04-19 Thread Kalle Valo
Erik Stromdahl wrote: > These wrappers makes the HTT ops align better with the HIF ops > (where similar wrappers are used). > > It also makes it easier for a target to have unsupported ops > (by letting the corresponding function pointer be NULL). > > Signed-off-by: Erik Stromdahl > Signed-off

Re: [v2] ath10k: search all IEs for variant before falling back

2018-04-19 Thread Kalle Valo
Kalle Valo wrote: > commit f2593cb1b291 ("ath10k: Search SMBIOS for OEM board file > extension") added a feature to ath10k that allows Board Data File > (BDF) conflicts between multiple devices that use the same device IDs > but have different calibration requirements to be resolved by allowing >

Re: [v2,01/13] ath10k: platform driver for WCN3990 SNOC WLAN module

2018-04-19 Thread Kalle Valo
Govind Singh wrote: > WCN3990 is integrated 802.11ac chipset with SNOC > bus interface. Add snoc layer driver registration > and associated ops. > > WCN3990 support is not yet complete as cold-boot > handshake is done using qmi(Qualcomm-MSM-Interface) > and qmi client support will be added once

Re: ath10k: Fix a typo in ath10k_wmi_set_wmm_param()

2018-04-19 Thread Kalle Valo
mke...@codeaurora.org wrote: > Fix a typo in the function ath10k_wmi_set_wmm_param(). > > Signed-off-by: Maharaja Kennadyrajan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. b022ca257ca6 ath10k: fix a typo in ath10k_wmi_set_wmm_param() -- https://patchwork.

Re: ath10k: correct target assert problem due to CE5 stuck

2018-04-19 Thread Kalle Valo
mpubb...@codeaurora.org wrote: > Correct a minor bug in the commit 0628467f97b5 ("ath10k: fix > copy engine 5 destination ring stuck") which introduced a change to fix > firmware assert that happens when ring indices of copy engine 5 are stuck > for a specific duration, problem with this fix is th

Re: ath10k: build ce layer in ath10k core module

2018-04-19 Thread Kalle Valo
Govind Singh wrote: > CE layer is shared between pci and snoc target and results > in duplicate object inclusion if both modules are compiled > together statically and undefined KBUILD_MODNAME if > compiled as module. > > Fix this by building ce layer in ath10k core module by > adding ce object

Re: [PATCHv3] ath10k: Add tx ack signal support for management frames

2018-04-19 Thread Kalle Valo
Venkateswara Naralasetty wrote: > This patch add support to get RSSI from acknowledgment > frames for transmitted management frames. > > hardware_used: QCA4019, QCA9984. > firmware version: 10.4-3.5.3-00052. > > Signed-off-by: Venkateswara Naralasetty > Signed-off-by: Kalle Valo Patch applie

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread Johannes Berg
On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: > > In order to efficiently parse lots of stats over and over again, I probe > the stat names once on startup, map them to the variable I am trying to use > (since different drivers may have different names for the same basic stat), > and then I

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-19 Thread Ben Greear
On 04/18/2018 11:38 PM, Johannes Berg wrote: On Wed, 2018-04-18 at 14:51 -0700, Ben Greear wrote: It'd be pretty hard to know which flags are firmware stats? Yes, it is, but ethtool stats are difficult to understand in a generic manner anyway, so someone using them is already likely aware o

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Kalle Valo
Sven Eckelmann writes: > On Donnerstag, 19. April 2018 14:33:04 CEST Kalle Valo wrote: >> >> Unfortunately, this is wrong. Please check the mail again. The >> >> bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=OM-A62 BDF is for the >> >> QCA9888 >> >> hw2.0 board-2.bin and not the QCA4019 hw1.0.

Re: ath10k-firmware: QCA4019 hw1.0: Add 8devices Jalapeno specific BDFs

2018-04-19 Thread Kalle Valo
Sven Eckelmann writes: > Robert Marko is currently trying to integrate the support for 8devices > Jalapeno in OpenWrt [1]. This module/board requires two special BDFs to get > the Wi-Fi PHYs working (correctly). The bmi-board-id='s would clash with one > of the the IPQ401X AP-DK boards because

Re: [PATCH 2/2] ath10k: search DT for qcom, ath10k-calibration-variant

2018-04-19 Thread Kalle Valo
Christian Lamparter writes: > On Friday, March 10, 2017 9:06:15 AM CET Sven Eckelmann wrote: >> Board Data File (BDF) is loaded upon driver boot-up procedure. The right >> board data file is identified on QCA4019 using bus, bmi-chip-id and >> bmi-board-id. >> >> The problem, however, can occur w

Re: QCA4019 hw1.0 - BDFs for Netgear EX6100v2 and EX6150v2

2018-04-19 Thread Kalle Valo
Thomas Hebb writes: > This is a set of board.bin files for the Netgear EX6100v2 [1] and > EX6150v2 [2] Wi-Fi range extenders. There are two files per device, > one for the 2.4GHz radio and one for the 5GHz one. All files were > extracted from Netgear's official v1.0.1.54 software update [3], whic

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Sven Eckelmann
On Donnerstag, 19. April 2018 14:33:04 CEST Kalle Valo wrote: > >> Unfortunately, this is wrong. Please check the mail again. The > >> bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=OM-A62 BDF is for the > >> QCA9888 > >> hw2.0 board-2.bin and not the QCA4019 hw1.0. > > > > Thanks for noticing, I

Re: ath10k-firmware: QCA4019 hw1.0: Add GL.iNet GL-B1300 specific BDFs

2018-04-19 Thread Kalle Valo
Dongming Han writes: > Tying to upstream BDFs of GL.iNet GL-B1300 to ath10k-firmware. > This router uses two changed BDFs based on > boardData_1_0_IPQ4019_Y9803_wifi0.bin & boardData_1_0_IPQ4019_Y9803_wifi1.bin. > We changed BDF for target power of both BDFs and FEM control parameter > antCtrlCom

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Kalle Valo
Kalle Valo writes: > Sven Eckelmann writes: > >> On Donnerstag, 19. April 2018 10:20:41 CEST Kalle Valo wrote: >> [...] >>> > - QCA4019 hw1.0 >>> > >>> > + bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=OM-A62 >>> > sha256sum: >>> > df5dc5a55506e2a58dcb0b8542f40226d3bfd530a6fc0b

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Kalle Valo
Sven Eckelmann writes: > On Donnerstag, 19. April 2018 10:20:41 CEST Kalle Valo wrote: > [...] >> > - QCA4019 hw1.0 >> > >> > + bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=OM-A62 >> > sha256sum: >> > df5dc5a55506e2a58dcb0b8542f40226d3bfd530a6fc0bc90c728ab18a57144c >> > + b

Re: ath10k-firmware: QCA4019 hw1.0: Add FRITZ!Box 4040 specific BDFs

2018-04-19 Thread Sven Eckelmann
On Dienstag, 17. April 2018 10:15:42 CEST Sven Eckelmann wrote: [...] > - QCA4019 hw1.0 > > + bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=AVM-FRITZBox-4040 > sha256sum: > eb866d036149fe4ba35f3f9d0d97e51969b1f1dbac6ea962daf9012ffa75427a > + bus=ahb,bmi-chip-id=0,bmi-board-id

Re: ath10k-firmware: QCA4019 hw1.0: Add FRITZ!Box 4040 specific BDFs

2018-04-19 Thread Kalle Valo
Sven Eckelmann writes: > The support for this device was added a while ago to OpenWrt. This AP > requires > two special BDFs to get the Wi-Fi PHYs working (correctly). The bmi-board- > id='s would clash with one of the the IPQ401X AP-DK boards because QCA > doesn't > provide special IDs for

Re: [PATCH 3/3] ath10k: Support ethtool gstats2 API.

2018-04-19 Thread kbuild test robot
Hi Ben, Thank you for the patch! Yet something to improve: [auto build test ERROR on mac80211/master] [also build test ERROR on v4.17-rc1 next-20180419] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Sven Eckelmann
On Donnerstag, 19. April 2018 10:20:41 CEST Kalle Valo wrote: [...] > > - QCA4019 hw1.0 > > > > + bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=OM-A62 > > sha256sum: > > df5dc5a55506e2a58dcb0b8542f40226d3bfd530a6fc0bc90c728ab18a57144c > > + bus=ahb,bmi-chip-id=0,bmi-board-id=2

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Kalle Valo
Sven Eckelmann writes: > I am currently starting to prepare the OpenMesh A62 support for Openwrt. This > > AP requires three special BDFs to get the Wi-Fi PHYs working (correctly). The > > bmi-board-id='s would clash with one of the the IPQ401X AP-DK boards because > QCA doesn't provide sp

Re: ath10k-firmware: QCA4019 hw1.0/QCA9888 hw2.0: Add OpenMesh A62 specific BDFs

2018-04-19 Thread Kalle Valo
Sven Eckelmann writes: > * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k) > > - QCA4019 hw1.0 > > + bus=ahb,bmi-chip-id=0,bmi-board-id=20,variant=OM-A62 > sha256sum: > df5dc5a55506e2a58dcb0b8542f40226d3bfd530a6fc0bc90c728ab18a57144c > + bus=ahb,bmi-ch

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

2018-04-19 Thread Kalle Valo
Kalle Valo writes: > Ben Greear writes: > >> It seems the upstream board-2.bin file for 9984 does not yet include >> support for WLE1216V5-20 >> (or possibly it does and OpenWRT grabs the wrong one?). >> >> I'm attaching the board file for this NIC and for another one which >> I have not yet tes

Re: Please add new board files for WLE1216V5-20 and another Compex NIC.

2018-04-19 Thread Kalle Valo
Ben Greear writes: > It seems the upstream board-2.bin file for 9984 does not yet include > support for WLE1216V5-20 > (or possibly it does and OpenWRT grabs the wrong one?). > > I'm attaching the board file for this NIC and for another one which > I have not yet tested. I received these from Co