Re: [PATCH v1 1/1] ath10k: convert kmemdup to dma_alloc_coherent

2018-04-24 Thread Kalle Valo
Jared Bents writes: > On Sat, Apr 21, 2018 at 2:10 AM, Kalle Valo wrote: >> Jared Bents writes: >> >>> Update to convert the use of kmemdup to dma_alloc_coherent as >>> dma_alloc_coherent will consider DMA region limits such as >>> those seen with CONFIG_FSL_PCI && CONFIG_ZONE_DMA32 whereas >>>

Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status()

2018-04-24 Thread Kalle Valo
Anilkumar Kolli writes: > Mesh path metric needs txrate information from ieee80211_tx_status() > call but in ath10k there is no mechanism to report tx rate information > via ieee80211_tx_status(), the rate is only accessible via > sta_statiscs() op. > > Per peer stats has tx rate info available,

Re: [PATCH] ath10k: fixed scan crash

2018-04-24 Thread Kalle Valo
zhic...@codeaurora.org writes: > From: Zhi Chen > > Length of WMI scan message was not calculated correctly. The allocated > buffer was smaller than what we expected. So WMI message corrupted > skb_info, which is at the end of skb->data. This fix takes TLV header > into account even if the elemen

Re: [PATCH] ath10k: add dynamic vlan support

2018-04-24 Thread Kalle Valo
Manikanta Pubbisetty writes: > Mutlicast/broadcast traffic destined for a particular vlan group will > always be encrypted in software. To enable dynamic VLANs, it requires > driver support for sending software encrypted packets. > > In ath10k, sending sw encrypted frames is allowed only when we

Re: [PATCHv3] ath10k: fix kernel panic while reading tpc_stats

2018-04-24 Thread Kalle Valo
Tamizh chelvam writes: > When attempt to read tpc_stats for the chipsets which support > more than 3 tx chain will trigger kernel panic(kernel stack is corrupted) > due to writing values on rate_code array out of range. > This patch changes the array size depends on the WMI_TPC_TX_N_CHAIN and > a

Re: [PATCH] ath10k: add dynamic vlan support

2018-04-24 Thread Sebastian Gottschall
consider my comment regarding vlan_ap. this patch will break wds ap / wds sta support with latest mac80211 (see also my post on the wireless mailing list about the breaking patch in mac80211) so AP_VLAN must be masked always for all chipsets. otherwise wds breaks and this is not just a guess. i

Re: [PATCH] ath10k: add dynamic vlan support

2018-04-24 Thread Manikanta Pubbisetty
Yes Sebastian, Your point is valid. This would break the 4-addr operation on other ath10k devices which does not support the new WMI service. I have another approach to solve this problem, I will come with a small patch and see what johannes has to say on that approach. Manikanta On 4/24/20

Re: [PATCH] ath10k: add dynamic vlan support

2018-04-24 Thread Kalle Valo
Sebastian Gottschall writes: > consider my comment regarding vlan_ap. I am considering comment, I just go one issue at a time and haven't had a time to look at your comment. But PLEASE do not top post, it's very annoying and creates a mess in patchwork. https://wireless.wiki.kernel.org/en/devel

Re: [PATCH] ath10k: add dynamic vlan support

2018-04-24 Thread Sebastian Gottschall
Am 24.04.2018 um 11:52 schrieb Kalle Valo: Sebastian Gottschall writes: consider my comment regarding vlan_ap. I am considering comment, I just go one issue at a time and haven't had a time to look at your comment. But PLEASE do not top post, it's very annoying and creates a mess in patchwork

Re: failed to run otp: -22

2018-04-24 Thread Arvid Picciani
yes, found it :) ath10k coming up now. thanks! On Mon, Apr 23, 2018 at 11:27 PM, Christian Lamparter wrote: > On Montag, 23. April 2018 22:31:22 CEST Arvid Picciani wrote: >> from where does ath10k know where to look for it? all i know about is >> ath79_register_wmac in arch init. That points to