Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips

2018-09-05 Thread Wen Gong
On 2018-09-05 07:43, Grant Grundler wrote: On Mon, Sep 3, 2018 at 6:35 AM Toke Høiland-Jørgensen wrote: Johannes Berg writes: > Grant's data shows a significant difference between 6 and 7 for both > latency and throughput: Minor nit: this is wgong's data more thoughtfully processed.

Re: [PATCHv2 3/3] ath10k: average ack rssi support for data frames

2018-09-05 Thread Balaji Pothunoori
On 2018-09-05 10:20, Kalle Valo wrote: Balaji Pothunoori writes: Average ack rssi value is weighted average of ack rssi for no of msdu's has been sent. This feature is enabled by the host driver if firmware is capable. After receiving event from host, firmware allocates the necessary memory to

[PATCH v3 3/3] ath10k: Add support to configure ftm responder role

2018-09-05 Thread Pradeep Kumar Chitrapu
Configure fine timing measurement (FTM) responder role from the ftm_responder bss param sent by mac80211. With FTM functionality offloaded to firmware, adding the interface allows userspace to enable FTM responder functionality. ath10k disables it at the time of interface creation. Supported FW: 1

[PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-05 Thread Pradeep Kumar Chitrapu
Currently ftm_responder parameter in hostapd.conf is only used for fine timing measurement (FTM) capability advertisement and actual control of the functionality is with low-level device/driver. This leads to confusion to the user when the capability advertisement is different from actual FTM respo

[PATCH v3 1/3] cfg80211: support FTM responder configuration/statistics

2018-09-05 Thread Pradeep Kumar Chitrapu
Allow userspace to enable fine timing measurement responder functionality with configurable LCI/Civic parameters in AP mode. This can be done at AP start or changing beacon parameters. A new EXT_FEATURE flag is introduced for drivers to advertise the capability. Also nl80211 API support for retri

[PATCH v3 2/3] mac80211: support FTM responder configuration/statistics

2018-09-05 Thread Pradeep Kumar Chitrapu
New bss param ftm_responder is used to notify the driver to enable fine timing request (FTM) responder role in AP mode. Plumb the new cfg80211 API for FTM responder statistics through to the driver API in mac80211. Signed-off-by: David Spinadel Signed-off-by: Johannes Berg Signed-off-by: Pradee

Re: [PATCH v2 2/3] mac80211: support FTM responder configuration/statistics

2018-09-05 Thread Pradeep Kumar Chitrapu
On 2018-09-03 02:33, Johannes Berg wrote: On Fri, 2018-08-31 at 12:56 -0700, Pradeep Kumar Chitrapu wrote: + * @ftm_responder: whether to enable fine timing measurement FTM functionality missing "responder" somewhere there :) + * @ftmr_params: configurable lci/civic parameter when enabling

[PATCH] ath10k: snoc: remove set but not used variable 'ar_snoc'

2018-09-05 Thread YueHaibing
From: Yue Haibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_tx_pipe_cleanup': drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning: variable 'ar_snoc' set but not used [-Wunused-but-set-variable] Signed-off-by: Yue Haibin

Re: [PATCH v3 0/3] support ftm responder configuration/statistics

2018-09-05 Thread Johannes Berg
On Wed, 2018-09-05 at 18:01 -0700, Pradeep Kumar Chitrapu wrote: > Currently ftm_responder parameter in hostapd.conf is only used for fine > timing measurement (FTM) capability advertisement and actual control of > the functionality is with low-level device/driver. This leads to confusion > to the

Re: [PATCH v2 2/3] mac80211: support FTM responder configuration/statistics

2018-09-05 Thread Johannes Berg
> > Perhaps the *existence* of ftmr_params could indicate that it's > > enabled? > > My understanding is these are only optional parameters. So, I have kept > ftm_responder separate from params. Yes, they're only optional. I was just thinking that even an "empty" set of parameters could indic