Re: [PATCH 3/3] ath10k: download firmware via diag Copy Engine for QCA6174 and QCA9377.

2018-09-21 Thread Brian Norris
Hi again! One last (?) comment: On Thu, Aug 30, 2018 at 10:29:42AM +0800, Carl Huang wrote: > diff --git a/drivers/net/wireless/ath/ath10k/hw.c > b/drivers/net/wireless/ath/ath10k/hw.c > index 677535b..25ee1c6 100644 > --- a/drivers/net/wireless/ath/ath10k/hw.c > +++

[PATCH] ath10k: add missing sanity check on diag download

2018-09-21 Thread Brian Norris
ath10k_hw_diag_fast_download() generally has good boundary checking, but it misses verifying that the next metadata header actually fits in the remaining buffer space. Add such a check. Fixes: 39501ea64116 ("ath10k: download firmware via diag Copy Engine for QCA6174 and QCA9377.") Signed-off-by:

Re: [PATCH 3/3] ath10k: download firmware via diag Copy Engine for QCA6174 and QCA9377.

2018-09-21 Thread Brian Norris
Hi, On Thu, Aug 30, 2018 at 10:29:42AM +0800, Carl Huang wrote: > diff --git a/drivers/net/wireless/ath/ath10k/hw.c > b/drivers/net/wireless/ath/ath10k/hw.c > index 677535b..25ee1c6 100644 > --- a/drivers/net/wireless/ath/ath10k/hw.c > +++ b/drivers/net/wireless/ath/ath10k/hw.c ... > +int

Re: [PATCH 3/3] ath10k: download firmware via diag Copy Engine for QCA6174 and QCA9377.

2018-09-21 Thread Brian Norris
Hi, I see this patch is already merged, but some small comments. Might be worth a follow-up patch eventually. On Thu, Aug 30, 2018 at 10:29:42AM +0800, Carl Huang wrote: > diff --git a/drivers/net/wireless/ath/ath10k/core.c > b/drivers/net/wireless/ath/ath10k/core.c > index c40cd12..78a0515

Re: [RFCv3 1/2] mac80211: implement ieee80211_tx_rate_update to update rate

2018-09-21 Thread Toke Høiland-Jørgensen
Anilkumar Kolli writes: > On 2018-09-20 21:40, Toke Høiland-Jørgensen wrote: >> Anilkumar Kolli writes: >> >>> Current mac80211 has provision to update tx status through >>> ieee80211_tx_status() and ieee80211_tx_status_ext(). But >>> drivers like ath10k updates the tx status from the skb

[PATCH 4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi module device node

2018-09-21 Thread Govind Singh
WCN3990 wifi module can optionally make use of the IOMMU. Add phandle to the iommu and stream id of wifi iommu block. Signed-off-by: Govind Singh --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi

[PATCH 3/4] dt: bindings: add bindings for wifi iommu node

2018-09-21 Thread Govind Singh
WCN3990 wifi module can optionally make use of the IOMMU. Add binding documentation for phandle to the IOMMU and the stream id of wifi iommu block. Signed-off-by: Govind Singh --- .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH 1/4] dt: bindings: add missing dt properties for WCN3990 wifi node

2018-09-21 Thread Govind Singh
Add missing optional properties in WCN3990 wifi node. Signed-off-by: Govind Singh --- .../bindings/net/wireless/qcom,ath10k.txt | 22 +-- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt

[PATCH 0/4] Enable ath10k wcn3990 wifi driver support on sdm845

2018-09-21 Thread Govind Singh
This series enables ath10k wifi driver support for WCN3990 target on sdm845 SOC. This series also updates the missing dt binding documentation and adds optional iommu property. sdm845 dtsi changes in this series are based on top of https://patchwork.kernel.org/cover/10573121/ change. Govind

[PATCH 2/4] dts: arm64/sdm845: Add WCN3990 WLAN module device node

2018-09-21 Thread Govind Singh
Add device node for the ath10k SNOC platform driver probe and add resources required for WCN3990 on SDM845 soc. Signed-off-by: Govind Singh --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 7 +++ arch/arm64/boot/dts/qcom/sdm845.dtsi| 25 + 2 files changed, 32