[PATCH][ath10k-next] ath10k: fix some spelling mistakes

2018-10-18 Thread Colin King
From: Colin Ian King Trivial fix to some spelling mistakes in ath10k_err and ath10k_dbg messages: "capablity" -> "capability" "registed" -> "registered" Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/qmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

Re: [PATCH 3/4] ath10k: snoc: relax voltage requirements

2018-10-18 Thread Brian Norris
On Thu, Oct 18, 2018 at 10:56 AM Doug Anderson wrote: > On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: > > > > I rarely see drivers specify precise voltage requirements like this, but > > if we really have to...let's at least give a little wiggle room. Board > > designs (and accompanying dev

Re: [PATCH 3/4] ath10k: snoc: relax voltage requirements

2018-10-18 Thread Doug Anderson
Hi, On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: > > I rarely see drivers specify precise voltage requirements like this, but > if we really have to...let's at least give a little wiggle room. Board > designs (and accompanying device trees) may not provide exactly the > voltage listed here,

Re: [PATCH 2/4] ath10k: snoc: fix unabalanced regulator error handling

2018-10-18 Thread Doug Anderson
Hi, On Fri, Oct 12, 2018 at 5:55 PM Brian Norris wrote: > + if (vreg_info->settle_delay) > + udelay(vreg_info->settle_delay); Not new to your patch, but this seems like a duplication of what the regulator framework is doing for you. There are plenty of regulator properties d

Re: [RFC 2/2] ath10k: Add QCA vendor command/attr support to filterneighbor BSS frames

2018-10-18 Thread Johannes Berg
On Fri, 2018-10-05 at 06:00 +, Kalle Valo wrote: > > So I'm not sure what to do with this. A bpf type of filtering system in > mac80211 would be nice Yes, I think we really need to start implementing that sooner rather than later. I had something, must see if I can find time for it. > but th

[PATCH] ath10k: Fixup extended per sta tx statistics

2018-10-18 Thread Dan Carpenter
I had a couple concerns with this code. First, we definitely need to set the error code if the kzalloc() fails. Secondly, I was worried that if we didn't set "arsta->tx_stats" to NULL after freeing it, then it looks to me like it might lead to a use after free. I can't test that, but it's harmle