Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"

2018-11-07 Thread Govind Singh
On 2018-11-08 03:00, Rajkumar Manoharan wrote: On 2018-11-07 10:56, Brian Norris wrote: This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. WCN3990 firmware does not yet implement this feature, and so it crashes like this: fatal error received:

Re: [PATCH 0/4] cfg80211/mac80211: Add support for TID specific configuration

2018-11-07 Thread Igor Mitsyanko
On 10/22/2018 10:55 AM, Tamizh chelvam wrote: > > Add infrastructure for per TID aggregation/retry count configurations > such as retry count and AMPDU aggregation control(disable/enable). > In some scenario reducing the number of retry count for a specific data > traffic can reduce the latency

[PATCH 4.20] ath10k: don't assume 'vif' is non-NULL in flush()

2018-11-07 Thread Brian Norris
mac80211 may call us with vif == NULL, if the station is not currently active (e.g., not associated). It is trivially easy to reproduce a crash by suspending the system when not connected to an AP: [ 65.533934] Unable to handle kernel NULL pointer dereference at virtual address

Re: [PATCH] ath10k: Add peer flush in ath10k_flush for STATION

2018-11-07 Thread Brian Norris
On Mon, Oct 8, 2018 at 2:03 AM Wen Gong wrote: > > In the noisy environment, if there are packets in the queue and can't > send out, the suspend timing will be more than 5 seconds due to the wait, > flush the queue to optimize the suspend timing, and let the upper layer to > retry the packets

Re: [PATCH 3/4] mac80211: Add api to support configuring TID specific configuration

2018-11-07 Thread Igor Mitsyanko
On 10/22/2018 10:55 AM, Tamizh chelvam wrote: > /** >* enum ieee80211_vif_flags - virtual interface flags >* > @@ -1565,6 +1594,8 @@ struct ieee80211_vif { > > bool txqs_stopped[IEEE80211_NUM_ACS]; > > + struct ieee80211_tid_conf tid_conf; > + Why is there only one TID

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-07 Thread Rajkumar Manoharan
On 2018-11-07 06:53, Toke Høiland-Jørgensen wrote: Rajkumar Manoharan writes: Meanwhile we did some more experiments with both modes. The experiment was done in open environment and fixed rate and UDP traffic ran for 60 seconds. Seems like push mode not honoring the configured weight. Always

Re: [PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"

2018-11-07 Thread Rajkumar Manoharan
On 2018-11-07 10:56, Brian Norris wrote: This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. WCN3990 firmware does not yet implement this feature, and so it crashes like this: fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0 This feature can be

[PATCH REGRESSION] Revert "ath10k: add quiet mode support for QCA6174/QCA9377"

2018-11-07 Thread Brian Norris
This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. WCN3990 firmware does not yet implement this feature, and so it crashes like this: fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0 This feature can be re-implemented with a proper service bitmap or

Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs

2018-11-07 Thread Toke Høiland-Jørgensen
Rajkumar Manoharan writes: > On 2018-11-02 03:30, Toke Høiland-Jørgensen wrote: >> Rajkumar Manoharan writes: >> >>> On 2018-10-28 15:01, Rajkumar Manoharan wrote: On 2018-10-28 08:48, Toke Høiland-Jørgensen wrote: > Rajkumar Manoharan writes: > >> >> 4ms 223

Re: [PATCH 1/4] New netlink command for TID specific configuration

2018-11-07 Thread Sergey Matyukevich
Hello Tamizh, > Co-Developed-by: Tamizh Chelvam > Signed-off-by: Vasanthakumar Thiagarajan > Signed-off-by: Tamizh chelvam > --- > include/net/cfg80211.h | 14 +++ > include/uapi/linux/nl80211.h | 69 + > net/wireless/nl80211.c | 86 >

Re: [PATCH 1/2] dt: bindings: add new dt entry to indentify external FEM

2018-11-07 Thread Bhagavathi Perumal S
On 2018-10-30 21:02, Rob Herring wrote: On Tue, Oct 30, 2018 at 3:41 AM wrote: On 2018-10-16 00:54, Rob Herring wrote: > On Thu, Oct 04, 2018 at 05:12:43PM +0530, Bhagavathi Perumal S wrote: >> This adds new dt entry ext-fem-name, it is used by ath10k driver >> to select correct timing