[PATCH 1/2] ath10k: Add support for adding htt_rx_ops based on htt_version

2019-02-26 Thread Surabhi Vishnoi
Refactor the code to add the support to attach htt_rx_ops based on HTT version. Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 Signed-off-by: Surabhi Vishnoi --- drivers/net/wireless/ath/ath10k/htt.h| 3 ++- drivers/net/wireless/ath/ath10k/htt_rx.c | 29

[PATCH 2/2] ath10k: Add support for per peer HTT tx stats for WCN3990

2019-02-26 Thread Surabhi Vishnoi
The firmware sends peer stats to the host driver if the firmware advertises WMI_SERVICE_PEER_STATS service and the host driver indicates the WMI_RSRC_CFG_FLAG_TX_PEER_STATS capability in the host capab flag in wmi init cmd. When peer stats are enabled, firmware sends one HTT event HTT_TLV_T2H_MSG_

[PATCH 0/2] Add support for per peer HTT tx stats for WCN3990

2019-02-26 Thread Surabhi Vishnoi
WCN3990 firmware sends the HTT_TLV_T2H_MSG_TYPE_PEER_STATS in tlv format so the handling of this message has to be done in different manner. This patchset adds support to attach rx_ops based on htt version and adds the handling of HTT_TLV_T2H_MSG_TYPE_PEER_STATS message based on HTT version. Sura

[PATCH 0/2] Add support for per peer HTT tx stats for WCN3990

2019-02-26 Thread Surabhi Vishnoi
WCN3990 firmware sends the HTT_TLV_T2H_MSG_TYPE_PEER_STATS in tlv format so the handling of this message has to be done in different manner. This patchset adds support to attach rx_ops based on htt version and adds the handling of HTT_TLV_T2H_MSG_TYPE_PEER_STATS message based on HTT version. Sura

Re: [PATCHv2 1/9] nl80211: New netlink command for TID specific configuration

2019-02-26 Thread Tamizh chelvam
Hi Sergey, Signed-off-by: Tamizh chelvam --- include/net/cfg80211.h | 35 +++ include/uapi/linux/nl80211.h | 51 ++ net/wireless/nl80211.c | 102 +++ net/wireless/rdev-ops.h | 11 + net/wireless/

Re: [PATCH] ath10k: update the max num of peers supported for WCN3990

2019-02-26 Thread Kalle Valo
Abhishek Ambure wrote: > WCN3990 firmware versions WLAN.HL.2.0-01617-QCAHLSWMTPLZ-1 & onwards > supports maximum 33 peers including self peer. To support maximum peers, > send updated peer param to firmware during initialization. > > Tested HW: WCN3990 > Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ

Re: [PATCH] ath10k: remove the calibration data fetch for sdio

2019-02-26 Thread Kalle Valo
Wen Gong wrote: > The calibration data fetch will trigger sdio error, then sdio will > become fail untill reboot system. > > If happens when run ifconfig wlan down, then ifconfig wlan up will > fail untill reboot system.Remove it fix the ifconfig wlan issue. > > Tested with QCA6174 SDIO with fi

Re: [PATCH] ath10k: Fix length of wmi tlv command for protected mgmt frames

2019-02-26 Thread Kalle Valo
Surabhi Vishnoi wrote: > The length of wmi tlv command for management tx send is calculated > incorrectly in case of protected management frames as there is addition > of IEEE80211_CCMP_MIC_LEN twice. This leads to improper behaviour of > firmware as the wmi tlv mgmt tx send command for protected

Re: [PATCH 1/4] ath10k: sdio: set hi_acs_flags

2019-02-26 Thread Kalle Valo
Kalle Valo wrote: > The SDIO firmware does not allow transmitting packets with the > reduced tx completion HI_ACS option. SDIO firmware uses 1544 as > alternate credit size, which is not big enough for the maximum sized > mac80211 frames. Disable both these HI_ACS flags for SDIO. > > Co-develope

Re: [PATCH] ath10k: correct the format of host memory chunks in wmi init command

2019-02-26 Thread Kalle Valo
Yu Wang wrote: > This is a theoretical fix, the issue is found in code review. > When adding the host memory chunks into wmi-tlv init command, > there is no separate tlv header for each host memory chunk > in the struct array, which breaches the convention between > host and firmware, will result

Re: [PATCH] ath10k: Enhance logging for vdev pdev & peer set param

2019-02-26 Thread Kalle Valo
Rakesh Pillai wrote: > Currently after enabling the WMI debug logging, > there is no detail printed about the param id > and the param value for the pdev, vdev and > peer params which are set. > > Enhance the WMI logging to print the param id > and the param value for pdev, vdev and peer set > p

Re: [PATCH v3 1/2] ath10k: Add support for ack rssi value of management tx packets

2019-02-26 Thread Kalle Valo
Abhishek Ambure wrote: > In WCN3990, WMI_TLV_SERVICE_TX_DATA_MGMT_ACK_RSSI service Indicates that > the firmware has the capability to send the RSSI value of the ACK for all > data and management packets transmitted. > > If WMI_RSRC_CFG_FLAG_TX_ACK_RSSI is set in host capability then firmware >

Re: [PATCH] ath10k: Fix descriptor size in ce tx completion for WCN3990

2019-02-26 Thread Kalle Valo
Rakesh Pillai wrote: > When the driver receives the tx completion of the > descriptor over ce, it clears the nbytes configured > for that particular descriptor. WCN3990 uses ce > descriptors with 64-bit address. > > Currently during handling the tx completion of the > descriptors, the nbytes are

Re: [PATCHv2 1/9] nl80211: New netlink command for TID specific configuration

2019-02-26 Thread Sergey Matyukevich
Hello Tamizh, > Signed-off-by: Tamizh chelvam > --- > include/net/cfg80211.h | 35 +++ > include/uapi/linux/nl80211.h | 51 ++ > net/wireless/nl80211.c | 102 > +++ > net/wireless/rdev-ops.h | 11 +

Re: [PATCHv2 8/9] ath10k: Add new api to support TID specific configuration

2019-02-26 Thread Sergey Matyukevich
Hello Tamizh, > This patch add ops for set_tid_config to support TID > specific configuration. STA information along with the > TID config change mask to notify driver that which configuration > needs to be applied for this current command. > If the STA info not available in the command then the >

Re: [PATCH] ath10k: Fill rx duration for each peer in fw_stats for WCN3990

2019-02-26 Thread Kalle Valo
Surabhi Vishnoi writes: > I have uploaded the v2 patch which fixes the warning. > https://patchwork.kernel.org/patch/10829811/ Thanks, but PLEASE do not top post. It's really annoying. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#do_not_top_post_and_edit_your_q

Re: ACS scans not returning noise floor

2019-02-26 Thread Kalle Valo
Justin Capella writes: > My apologies, > I left out the important bit of the debug logs > [ 1265.917324] ath10k_warn: 61 callbacks suppressed > [ 1265.917330] ath10k_pci :01:00.0: failed to parse chan info event: -71 > > Possibly also relevant, i'm using country "US" I am aware that the fcc >

Re: [PATCH] ath10k: Fill rx duration for each peer in fw_stats for WCN3990

2019-02-26 Thread Surabhi Vishnoi
Hi Kalle, I have uploaded the v2 patch which fixes the warning. https://patchwork.kernel.org/patch/10829811/ Thanks, Surabhi Vishnoi On 2019-02-25 22:47, Kalle Valo wrote: Surabhi Vishnoi wrote: Currently, rx_duration for each peer is not getting populated in fw_stats debugfs entry for

[PATCH v2] ath10k: Fill rx duration for each peer in fw_stats for WCN3990

2019-02-26 Thread Surabhi Vishnoi
Currently, rx_duration for each peer is not getting populated in fw_stats debugfs entry for WCN3990. WCN3990 firmware sends rx duration for each peer as part of peer_extd_stats in WMI_UPDATE_STATS_EVENT. To enable peer_extd_stats, firmware expects host to send fw_stats_req_mask with flag WMI_TLV_P

[PATCH v2 3/4] ath10k: Fix the wrong updation of SGI in tx_stats debugfs

2019-02-26 Thread Surabhi Vishnoi
The SGI is updated wrongly in tx stats table in debugfs per sta entry. To know whether the packets/bytes are sent with SHORT GI, test whether the SGI bit(ATH10K_RATE_INFO_FLAGS_SGI_BIT) is set or not in the txrate flags. Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 Fixes: a90441

[PATCH v2 4/4] ath10k: Fix the wrong calculation ht_idx and idx of rate table for tx_stats

2019-02-26 Thread Surabhi Vishnoi
ht_idx (ht rate index) and idx (rate table index) are calculated based on mcs index. This mcs index used in the above calculation should be 0-9 for getting the correct ht_idx and idx. Currently the mcs index used for the above calculations is mcs index which can be 0-31 (in case of HT), leading to

[PATCH v2 2/4] ath10k: Fix the wrong updation of BW in tx_stats debugfs entry

2019-02-26 Thread Surabhi Vishnoi
Currently, the bandwidth is updated wrongly in BW table in tx_stats debugfs per sta as there is difference in number of bandwidth type in mac80211 and driver stats table. This leads to bandwidth getting updated at wrong index in bandwidth table in tx_stats. Fix this index mismatch between mac80211

[PATCH v2 1/4] ath10k: Fix the incorrect updation of NSS data in tx stats

2019-02-26 Thread Surabhi Vishnoi
The NSS data is updated incorrectly in the tx stats as the array indexing starts from zero. Fix the incorrect updation of NSS data in tx_stats by taking into consideration the array index starting from zero. Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 Fixes: a904417fc876 ("ath

[PATCH v2 0/4] Fix inconsistencies observed in population of tx_stats in debugfs

2019-02-26 Thread Surabhi Vishnoi
There are some inconsistencies observed while filling various peer tx stats in tx_stats debugfs entry per sta. This patchset fixes the wrong updation of NSS, SGI, Bandwidth and rate_table in tx_stats debugfs entry per sta. Changes from v1: -Initialized the uninitialized variable flags in [Patch

Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting

2019-02-26 Thread Sven Eckelmann
On Monday, 25 February 2019 21:00:38 CET Sven Eckelmann wrote: [...] > Tested-by: Sven Eckelmann > > Was tested on QCA988X with 10.2.4-1.0-00041 I just wanted to test it with 802.11s setup on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053 (ath10k-firmware) and 10.4-3.6-00140 (l

Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets

2019-02-26 Thread Sven Eckelmann
On Friday, 6 April 2018 17:17:55 CET Kalle Valo wrote: > From: Sebastian Gottschall > > Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based > chipsets with on chipset connected led's using WMI Firmware API. The LED > device will get available named as "ath10k-phyX" at sysfs