Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-16 Thread Toke Høiland-Jørgensen
Erik Stromdahl writes: > On 4/1/19 1:05 PM, Toke Høiland-Jørgensen wrote: >> Erik Stromdahl writes: >> >>> Iterating the TX queue and thereby dequeuing all available packets in the >>> queue could result in performance penalties on some SMP systems. >>> >>> The reason for this is most likely

Re: [PATCH] ath10k: remove iteration in wake_tx_queue

2019-04-16 Thread Erik Stromdahl
On 4/1/19 1:05 PM, Toke Høiland-Jørgensen wrote: Erik Stromdahl writes: Iterating the TX queue and thereby dequeuing all available packets in the queue could result in performance penalties on some SMP systems. The reason for this is most likely that the per-ac lock (active_txq_lock) in

[PATCH] ath10k: add support for simulate crash on SDIO chip

2019-04-16 Thread Wen Gong
The command to simulate firmware crash: echo soft > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash It will send WMI_FORCE_FW_HANG_ASSERT to firmware, then it will trigger CPU interrupt status register for SDIO chip, ath10k driver need to configure it while enable SDIO interrupt,

Re: [PATCH] mac80211: Fix kernel panic due to use of txq after free

2019-04-16 Thread Toke Høiland-Jørgensen
Bhagavathi Perumal S writes: > The txq of vif is added to active_txqs list for ATF TXQ scheduling > in the function ieee80211_queue_skb(), but it was not properly removed > before freeing the txq object. It was causing use after free of the txq > objects from the active_txqs list, result was

[PATCH] mac80211: Fix kernel panic due to use of txq after free

2019-04-16 Thread Bhagavathi Perumal S
The txq of vif is added to active_txqs list for ATF TXQ scheduling in the function ieee80211_queue_skb(), but it was not properly removed before freeing the txq object. It was causing use after free of the txq objects from the active_txqs list, result was kernel panic due to invalid memory access.