Re: [PATCH v3 8/8] ath10k: enable napi on RX path for sdio

2019-08-29 Thread Nicolas Boichat
On Fri, Aug 30, 2019 at 1:50 AM Wen Gong wrote: > > For tcp RX, the quantity of tcp acks to remote is 1/2 of the quantity > of tcp data from remote, then it will have many small length packets > on TX path of sdio bus, then it reduce the RX packets's bandwidth of > tcp. > > This patch enable napi

Re: [PATCH v3 7/8] ath10k: enable alt data of TX path for sdio

2019-08-29 Thread Nicolas Boichat
On Fri, Aug 30, 2019 at 1:39 AM Wen Gong wrote: > > The default credit size is 1792 bytes, but the IP mtu is 1500 bytes, > then it has about 290 bytes's waste for each data packet on sdio > transfer path for TX bundle, it will reduce the transmission utilization > ratio for data packet. > > This

Re: [PATCH v3 2/8] ath10k: enable RX bundle receive for sdio

2019-08-29 Thread Nicolas Boichat
On Thu, Aug 29, 2019 at 11:49 PM Wen Gong wrote: > > From: Alagu Sankar > > The existing implementation of initiating multiple sdio transfers for > receive bundling is slowing down the receive speed. Combining the > transfers using a bundle method would be ideal. > > The transmission utilization

Re: [PATCH v3 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet

2019-08-29 Thread Nicolas Boichat
On Fri, Aug 30, 2019 at 10:53 AM Nicolas Boichat wrote: > > On Thu, Aug 29, 2019 at 12:18 AM Wen Gong wrote: > > > > When the FW bundles multiple packets, pkt->act_len may be incorrect > > as it refers to the first packet only (however, the FW will only > > bundle packets that fit into the same

RE: [PATCH] ath10k: add fw coredump for sdio when firmware assert

2019-08-29 Thread Wen Gong
> -Original Message- > From: ath10k On Behalf Of Wen Gong > Sent: Wednesday, August 28, 2019 1:00 PM > To: Nicolas Boichat ; Wen Gong > > Cc: Brian Norris ; open list:NETWORKING > DRIVERS (WIRELESS) ; > ath10k@lists.infradead.org > Subject: [EXT] RE: [PATCH] ath10k: add fw coredump for

Re: [PATCH v3 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet

2019-08-29 Thread Nicolas Boichat
On Thu, Aug 29, 2019 at 12:18 AM Wen Gong wrote: > > When the FW bundles multiple packets, pkt->act_len may be incorrect > as it refers to the first packet only (however, the FW will only > bundle packets that fit into the same pkt->alloc_len). > > Before this patch, the skb length would be set

RE: [PATCH v2 7/7] ath10k: enable napi on RX path for sdio

2019-08-29 Thread Wen Gong
> -Original Message- > From: ath10k On Behalf Of Nicolas > Boichat > Sent: Wednesday, August 28, 2019 1:40 PM > To: Wen Gong > Cc: open list:NETWORKING DRIVERS (WIRELESS) wirel...@vger.kernel.org>; ath10k@lists.infradead.org > Subject: [EXT] Re: [PATCH v2 7/7] ath10k: enable napi on RX

RE: [PATCH v2 6/7] ath10k: enable alt data of TX path for sdio

2019-08-29 Thread Wen Gong
> -Original Message- > From: ath10k On Behalf Of Nicolas > Boichat > Sent: Wednesday, August 28, 2019 1:38 PM > To: Wen Gong > Cc: open list:NETWORKING DRIVERS (WIRELESS) wirel...@vger.kernel.org>; ath10k@lists.infradead.org > Subject: [EXT] Re: [PATCH v2 6/7] ath10k: enable alt data of

RE: [PATCH v2 5/7] ath10k: add htt TX bundle for sdio

2019-08-29 Thread Wen Gong
> -Original Message- > From: ath10k On Behalf Of Wen Gong > Sent: Wednesday, August 28, 2019 9:03 PM > To: Nicolas Boichat ; Wen Gong > > Cc: open list:NETWORKING DRIVERS (WIRELESS) wirel...@vger.kernel.org>; ath10k@lists.infradead.org > Subject: [EXT] RE: [PATCH v2 5/7] ath10k: add htt

RE: [PATCH v2 3/7] ath10k: add workqueue for RX path of sdio

2019-08-29 Thread Wen Gong
-Original Message- From: ath10k On Behalf Of Nicolas Boichat Sent: Wednesday, August 28, 2019 1:17 PM To: Wen Gong Cc: open list:NETWORKING DRIVERS (WIRELESS) ; ath10k@lists.infradead.org Subject: [EXT] Re: [PATCH v2 3/7] ath10k: add workqueue for RX path of sdio Changed and V3 sent,

RE: [PATCH v2 2/7] ath10k: change max RX bundle size from 8 to 32 for sdio

2019-08-29 Thread Wen Gong
-Original Message- From: ath10k On Behalf Of Nicolas Boichat Sent: Wednesday, August 28, 2019 1:14 PM To: Wen Gong Cc: open list:NETWORKING DRIVERS (WIRELESS) ; ath10k@lists.infradead.org Subject: [EXT] Re: [PATCH v2 2/7] ath10k: change max RX bundle size from 8 to 32 for sdio Changed

[PATCH v2] ath10k: add fw coredump for sdio when firmware assert

2019-08-29 Thread Wen Gong
When firmware assert, it need coredump to analyze, this patch will collect the register and memory info for sdio chip. The coredump configuration is different between PCIE and SDIO for the same reversion, so this patch add bus type to distinguish PCIE and SDIO chip for coredump. Tested with

[PATCH] ath10k: fix latency issue for QCA988x

2019-08-29 Thread Miaoqing Pan
Bad latency is found on QCA988x, the issue was introduced by commit 4504f0e5b571 ("ath10k: sdio: workaround firmware UART pin configuration bug"). If uart_pin_workaround is false, this change will set uart pin even if uart_print is false. Tested HW: QCA9880 Tested FW: 10.2.4-1.0-00037 Fixes:

[PATCH v3 8/8] ath10k: enable napi on RX path for sdio

2019-08-29 Thread Wen Gong
For tcp RX, the quantity of tcp acks to remote is 1/2 of the quantity of tcp data from remote, then it will have many small length packets on TX path of sdio bus, then it reduce the RX packets's bandwidth of tcp. This patch enable napi on RX path, then the RX packet of tcp will not feed to tcp

[PATCH v3 3/8] ath10k: change max RX bundle size from 8 to 32 for sdio

2019-08-29 Thread Wen Gong
The max bundle size support by firmware is 32, change it from 8 to 32 will help performance. This results in significant performance improvement on RX path. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-7-QCARMSWP-1. Signed-off-by: Wen Gong --- v2:change macro HTC_GET_BUNDLE_COUNT

[PATCH v3 5/8] ath10k: disable TX complete indication of htt for sdio

2019-08-29 Thread Wen Gong
Tx complete message from firmware cost bus bandwidth of sdio, and bus bandwidth is the bollteneck of throughput, it will effect the bandwidth occupancy of data packet of TX and RX. This patch disable TX complete indication from firmware for htt data packet, it results in significant performance

[PATCH v3 7/8] ath10k: enable alt data of TX path for sdio

2019-08-29 Thread Wen Gong
The default credit size is 1792 bytes, but the IP mtu is 1500 bytes, then it has about 290 bytes's waste for each data packet on sdio transfer path for TX bundle, it will reduce the transmission utilization ratio for data packet. This patch enable the small credit size in firmware, firmware will

[PATCH v3 4/8] ath10k: add workqueue for RX path of sdio

2019-08-29 Thread Wen Gong
The thread of read rx message by sdio bus from firmware is synchronous, it will cost much time for process the left part of rx message which includes indicate the rx packet to uppper net stack. It will reduce the time of read from sdio. This patch move the indication to a workqueue, it results in

[PATCH v3 2/8] ath10k: enable RX bundle receive for sdio

2019-08-29 Thread Wen Gong
From: Alagu Sankar The existing implementation of initiating multiple sdio transfers for receive bundling is slowing down the receive speed. Combining the transfers using a bundle method would be ideal. The transmission utilization ratio for sdio bus for small packet is slow, because the space

[PATCH v3 6/8] ath10k: add htt TX bundle for sdio

2019-08-29 Thread Wen Gong
The transmission utilization ratio for sdio bus for small packet is slow, because the space and time cost for sdio bus is same for large length packet and small length packet. So the speed of data for large length packet is higher than small length. Test result of different length of data: data

problems with a 9377 based SDIO module

2019-08-29 Thread Greg Ungerer
Hi Erik, I have a Compex WSD377 WiFi module with SDIO interface on a new iMX6 based platform. I am trying to get the module going but am having problems with it at probe/init time. Ultimately what I see at ath10k_sdio module load time is: <4>ath10k_sdio mmc0:0001:1: WARNING: ath10k SDIO