Re: [PATCH] ath10k: remove TX lock from ath10k_htt_tx_inc_pending

2019-09-17 Thread Kalle Valo
Erik Stromdahl wrote: > This commit removes the call to ath10k_mac_tx_lock() from > ath10k_htt_tx_inc_pending() in case the high water mark is reached. > > ath10k_mac_tx_lock() calls ieee80211_stop_queues() in order to stop > mac80211 from pushing more TX data to the driver (this is the TX lock)

Re: [PATCH] ath10k: Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

2019-09-17 Thread Kalle Valo
zhong jiang wrote: > With the help of Coccinelle, ARRAY_SIZE can be replaced in > ath10k_snoc_wlan_enable. > > Signed-off-by: zhong jiang I already got an identical patch so dropping this one. error: patch failed: drivers/net/wireless/ath/ath10k/snoc.c:976 error: drivers/net/wireless/ath/ath

Re: [PATCH] ath10k: Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

2019-09-17 Thread Kalle Valo
zhong jiang wrote: > With the help of Coccinelle, ARRAY_SIZE can be replaced in > ath10k_snoc_wlan_enable. > > Signed-off-by: zhong jiang I already got an identical patch so dropping this one. error: patch failed: drivers/net/wireless/ath/ath10k/snoc.c:976 error: drivers/net/wireless/ath/ath

Re: [PATCH v2] ath10k: fix max antenna gain unit

2019-09-17 Thread Kalle Valo
+ Govind, Wen Sven Eckelmann writes: > From: Sven Eckelmann > > Most of the txpower for the ath10k firmware is stored as twicepower (0.5 dB > steps). This isn't the case for max_antenna_gain - which is still expected > by the firmware as dB. > > The firmware is converting it from dB to the inte

ath10k-firmware: QCA4019 hw1.0: Add EnGenius EMD1 specific BDFs

2019-09-17 Thread frank.shen
Hi, The support for this device was added a while ago to OpenWrt. This AP requires two special BDFs to get the Wi-Fi PHYs working (correctly). The bmi-board-id='s would clash with one of the the IPQ401X AP-DK boards because QCA doesn't provide special IDs for customers and seems to use the AP-D

Re: [PATCH] ath10k: Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

2019-09-17 Thread zhong jiang
On 2019/9/17 15:16, Kalle Valo wrote: > zhong jiang wrote: > >> With the help of Coccinelle, ARRAY_SIZE can be replaced in >> ath10k_snoc_wlan_enable. >> >> Signed-off-by: zhong jiang > I already got an identical patch so dropping this one. > > error: patch failed: drivers/net/wireless/ath/ath10

Re: [PATCH] ath10k: Check if station exists before forwarding tx airtime report

2019-09-17 Thread Kalle Valo
Hauke Mehrtens wrote: > It looks like the FW on QCA9984 already reports the tx airtimes before > the station is added to the peer entry. The peer entry is created in > ath10k_peer_map_event() just with the vdev_id and the ethaddr, but > not with a station entry, this is added later in ath10k_peer

Re: [PATCH] ath10k: Check if station exists before forwarding tx airtime report

2019-09-17 Thread Kalle Valo
Hauke Mehrtens wrote: > It looks like the FW on QCA9984 already reports the tx airtimes before > the station is added to the peer entry. The peer entry is created in > ath10k_peer_map_event() just with the vdev_id and the ethaddr, but > not with a station entry, this is added later in ath10k_peer

Re: [PATCH] ath10k: Fix HOST capability QMI incompatibility

2019-09-17 Thread Kalle Valo
Bjorn Andersson wrote: > The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI > message") served the purpose of supporting the new and extended HOST > capability QMI message. > > But while the new message adds a slew of optional members it changes the > data type of the "daemon_

Re: [PATCH] ath10k: Fix HOST capability QMI incompatibility

2019-09-17 Thread Kalle Valo
Bjorn Andersson wrote: > The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI > message") served the purpose of supporting the new and extended HOST > capability QMI message. > > But while the new message adds a slew of optional members it changes the > data type of the "daemon_

Re: [PATCH 1/3] ath10k: snoc: skip regulator operations

2019-09-17 Thread Kalle Valo
Bjorn Andersson wrote: > The regulator operations is trying to set a voltage to a fixed value, by > giving some wiggle room. But some board designs specifies regulator > voltages outside this limited range. One such example is the Lenovo Yoga > C630, with vdd-3.3-ch0 in particular specified at 3.

Re: [PATCH 1/3] ath10k: snoc: skip regulator operations

2019-09-17 Thread Kalle Valo
Bjorn Andersson wrote: > The regulator operations is trying to set a voltage to a fixed value, by > giving some wiggle room. But some board designs specifies regulator > voltages outside this limited range. One such example is the Lenovo Yoga > C630, with vdd-3.3-ch0 in particular specified at 3.

Re: [PATCH v3] ath10k: avoid leaving .bss_info_changed prematurely

2019-09-17 Thread Kalle Valo
Sven Eckelmann wrote: > ath10k_bss_info_changed() handles various events from the upper layers. It > parses the changed bitfield and then configures the driver/firmware > accordingly. Each detected event is handled in a separate scope which is > independent of each other - but in the same functio

Re: [PATCH v3] ath10k: avoid leaving .bss_info_changed prematurely

2019-09-17 Thread Kalle Valo
Sven Eckelmann wrote: > ath10k_bss_info_changed() handles various events from the upper layers. It > parses the changed bitfield and then configures the driver/firmware > accordingly. Each detected event is handled in a separate scope which is > independent of each other - but in the same functio

Re: [PATCH] ath10k: Use ARRAY_SIZE

2019-09-17 Thread Kalle Valo
Vasyl Gomonovych wrote: > fix coccinelle warning, use ARRAY_SIZE > > Signed-off-by: Vasyl Gomonovych > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7921ae091907 ath10k: Use ARRAY_SIZE -- https://patchwork.kernel.org/patch/11049553/ https://wireless.wiki.k

Re: [PATCH] ath10k: Use ARRAY_SIZE

2019-09-17 Thread Kalle Valo
Vasyl Gomonovych wrote: > fix coccinelle warning, use ARRAY_SIZE > > Signed-off-by: Vasyl Gomonovych > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7921ae091907 ath10k: Use ARRAY_SIZE -- https://patchwork.kernel.org/patch/11049553/ https://wireless.wiki.k

Re: [PATCH] ath10k: revalidate the msa region coming from firmware

2019-09-17 Thread Kalle Valo
Govind Singh wrote: > driver sends QMI_WLFW_MSA_INFO_REQ_V01 QMI request to firmware > and in response expects range of addresses and size to be mapped. > Add condition to check whether addresses in response falls > under valid range otherwise return failure. > > Testing: Tested on WCN3990 HW >

Re: [PATCH] ath10k: revalidate the msa region coming from firmware

2019-09-17 Thread Kalle Valo
Govind Singh wrote: > driver sends QMI_WLFW_MSA_INFO_REQ_V01 QMI request to firmware > and in response expects range of addresses and size to be mapped. > Add condition to check whether addresses in response falls > under valid range otherwise return failure. > > Testing: Tested on WCN3990 HW >

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-09-17 Thread Kalle Valo
Wenwen Wang wrote: > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > go to the 'exit' label. > > Signed-off-by: Wenwen Wang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of

Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()

2019-09-17 Thread Kalle Valo
Wenwen Wang wrote: > If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource > leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before > go to the 'exit' label. > > Signed-off-by: Wenwen Wang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of

Re: [PATCH] ath10k: fix latency issue for QCA988x

2019-09-17 Thread Kalle Valo
Miaoqing Pan wrote: > Bad latency is found on QCA988x, the issue was introduced by > commit 4504f0e5b571 ("ath10k: sdio: workaround firmware UART > pin configuration bug"). If uart_pin_workaround is false, this > change will set uart pin even if uart_print is false. > > Tested HW: QCA9880 > Test

Re: [PATCH] ath10k: fix latency issue for QCA988x

2019-09-17 Thread Kalle Valo
Miaoqing Pan wrote: > Bad latency is found on QCA988x, the issue was introduced by > commit 4504f0e5b571 ("ath10k: sdio: workaround firmware UART > pin configuration bug"). If uart_pin_workaround is false, this > change will set uart pin even if uart_print is false. > > Tested HW: QCA9880 > Test

Re: [PATCH] ath10k: fix spelling mistake "eanble" -> "enable"

2019-09-17 Thread Kalle Valo
Colin King wrote: > There is a spelling mistake in a ath10k_warn warning message. Fix it. > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 09764659003d ath10k: fix spelling mistake "eanble" -> "enable" -- https://patchwork.k

Re: [PATCH] ath10k: fix spelling mistake "eanble" -> "enable"

2019-09-17 Thread Kalle Valo
Colin King wrote: > There is a spelling mistake in a ath10k_warn warning message. Fix it. > > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 09764659003d ath10k: fix spelling mistake "eanble" -> "enable" -- https://patchwork.k

Re: [PATCH 1/4] mac80211: Switch to a virtual time-based airtime scheduler

2019-09-17 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > From: Toke Høiland-Jørgensen > > This switches the airtime scheduler in mac80211 to use a virtual time-based > scheduler instead of the round-robin scheduler used before. This has a > couple of advantages: Thank you for keeping at this! I'll take a look at the series in deta

Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature

2019-09-17 Thread Brian Norris
Since Wen has once again suggested I use this patch in other forums, I'll ping here to note: On Wed, Nov 14, 2018 at 2:59 PM Brian Norris wrote: > You've introduced a regression in 4.20-rc1: This regression still survives in the latest tree. Is it fair to just submit a revert? Brian

Re: [PATCH] cfg80211: Add cumulative channel survey dump support.

2019-09-17 Thread Sven Eckelmann
On Thursday, 31 May 2018 11:06:59 CEST vnara...@codeaurora.org wrote: > I will sent next version of patch with updated commit log. Can you please point me to the second version? Btw. I've just checked the minimal changes in ath10k to get this working. It seems we need SURVEY_INFO_NON_ACC_DATA in

Re: [PATCH] cfg80211: Add cumulative channel survey dump support.

2019-09-17 Thread Ben Greear
On 9/17/19 10:27 AM, Sven Eckelmann wrote: On Thursday, 31 May 2018 11:06:59 CEST vnara...@codeaurora.org wrote: I will sent next version of patch with updated commit log. Can you please point me to the second version? Btw. I've just checked the minimal changes in ath10k to get this working.

Re: [PATCH 2/4] mac80211: defer txqs removal from rbtree

2019-09-17 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > In a loop txqs dequeue scenario, if the first txq in the rbtree gets > removed from rbtree immediately in the ieee80211_return_txq(), the > loop will break soon in the ieee80211_next_txq() due to schedule_pos > not leading to the second txq in the rbtree. Thus, defering the >

Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

2019-09-17 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > On 2019-09-16 23:27, Johannes Berg wrote: >> Without really looking at the code - >> >>> If station is ineligible for transmission in >>> ieee80211_txq_may_transmit(), >>> no packet will be delivered to FW. During the tests in push-pull mode >>> with >>> many clients, after

Re: [PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together

2019-09-17 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > Global airtime weight sum is updated only when txq is added/removed > from rbtree. If upper layer configures sta weight during high load, > airtime weight sum will not be updated since txq is most likely on the > tree. It could a little late for upper layer to reconfigure sta

Re: [PATCH 1/4] mac80211: Switch to a virtual time-based airtime scheduler

2019-09-17 Thread Toke Høiland-Jørgensen
Yibo Zhao writes: > From: Toke Høiland-Jørgensen > > This switches the airtime scheduler in mac80211 to use a virtual time-based > scheduler instead of the round-robin scheduler used before. This has a > couple of advantages: > > - No need to sync up the round-robin scheduler in firmware/hardwar